From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Jonas Aaberg <jonas.aberg@stericsson.com>,
Bengt JONSSON <bengt.g.jonsson@stericsson.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error
Date: Tue, 19 Feb 2013 15:30:24 +0000 [thread overview]
Message-ID: <20130219153024.GA4098@gmail.com> (raw)
In-Reply-To: <1361287233.23734.1.camel@phoenix>
On Tue, 19 Feb 2013, Axel Lin wrote:
> This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.
>
> drivers/built-in.o: In function `ab8500_power_off':
> drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
> drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 671f5b1..c346941 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -858,6 +858,7 @@ config EZX_PCAP
> config AB8500_CORE
> bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
> depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
> + select POWER_SUPPLY
> select MFD_CORE
> select IRQ_DOMAIN
> help
I noticed and was going to fix this up myself - it's the right thing
to do.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-02-19 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 15:20 [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error Axel Lin
2013-02-19 15:30 ` Lee Jones [this message]
2013-03-13 8:34 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219153024.GA4098@gmail.com \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=jonas.aberg@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.