From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH TINYCOMPRESS 1/14] compress: Add function to get timestamp in samples
Date: Tue, 19 Feb 2013 17:24:29 +0000 [thread overview]
Message-ID: <20130219172429.GB32279@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130211063448.GA3789@intel.com>
>I am fine with adding new API for returning the samples, but then why return the
>raw struct. Would make sense to just get samples if that is only thing desired.
Is there a need to hide the underlying ALSA structs from a client of tinyalsa?
If so, why?
Might other fields in snd_compr_tstamp be useful to the client? If so it's cleaner
to just return them all instead of having to spawn several different functions the
client has to call to get a snd_compr_tstamp and then return each field separately.
If snd_compr_tstamp is basically useless to any tinycompress client except for
the value of pcm_io_frames (and maybe sampling_rate?) then I'm ok with just
returning those instead of the raw snd_compr_tstamp.
next prev parent reply other threads:[~2013-02-19 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 0:02 [PATCH TINYCOMPRESS 1/14] compress: Add function to get timestamp in samples Richard Fitzgerald
2013-02-11 6:34 ` Vinod Koul
2013-02-11 14:11 ` Pierre-Louis Bossart
2013-02-19 17:18 ` Richard Fitzgerald
2013-02-19 17:24 ` Richard Fitzgerald [this message]
2013-02-20 5:50 ` Vinod Koul
2013-02-22 15:56 ` [PATCH TINYCOMPRESS 1/14 v2] " Richard Fitzgerald
2013-02-22 18:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219172429.GB32279@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.