From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/libxc: perpare xc_domain_save for upcoming changes
Date: Tue, 19 Feb 2013 19:54:10 +0100 [thread overview]
Message-ID: <20130219185410.GC21783@aepfle.de> (raw)
In-Reply-To: <20771.48457.150475.736921@mariner.uk.xensource.com>
On Tue, Feb 19, Ian Jackson wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH] tools/libxc: perpare xc_domain_save for upcoming changes"):
> > tools/libxc: perpare xc_domain_save for upcoming changes
> >
> > An upcoming patch will pass min_remaining to xc_domain_save.
> > Because such a will be an API change, take the opportunity to change the
> > API so that it will be easier to pass more options in the future.
>
> I'm not sure why changing the large number of arguments to
> xc_domain_save to a struct is an improvement, even given that you are
> proposing to add one. Can you explain further ?
If new parameters will be passed into xc_domain_save it will change the
API every time. If instead such parameters are stuffed into a struct the
API will not change for callers, if the new struct member is really
optional.
I'm fine with adding yet another parameter to xc_domain_save, given that
there are appearently no external callers. libvirt uses libxl.
Olaf
prev parent reply other threads:[~2013-02-19 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 20:09 [PATCH] tools/libxc: perpare xc_domain_save for upcoming changes Olaf Hering
2013-02-19 17:58 ` Ian Jackson
2013-02-19 18:54 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219185410.GC21783@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.