From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: highbank: remove DRAM bank setup
Date: Tue, 19 Feb 2013 20:27:23 +0100 [thread overview]
Message-ID: <20130219192723.75779200530@gemini.denx.de> (raw)
In-Reply-To: <1359085160-28675-2-git-send-email-robherring2@gmail.com>
Dear Rob Herring,
In message <1359085160-28675-2-git-send-email-robherring2@gmail.com> you wrote:
>
> The memory sizes in highbank dtb's are already correct, so remove the DRAM
> bank setup so the memory node is not fixed up by u-boot.
I think you do more here...
> -void dram_init_banksize(void)
> -{
> - gd->bd->bi_dram[0].start = CONFIG_SYS_SDRAM_BASE;
> - gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> -}
...
> -#define CONFIG_NR_DRAM_BANKS 1
> +#define CONFIG_NR_DRAM_BANKS 0
I think this is a very bad idea, as you will now be no longer possible
to get information about memory sizes from U-Boot. For exmaple,
"bdinfo" will not print any reasonable value any more.
Please don't do that!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ever try. Ever fail. No matter. Try again. Fail again. Fail better.
-- S. Beckett
next prev parent reply other threads:[~2013-02-19 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 3:39 [U-Boot] [PATCH 1/2] ARM: bootm: allow skipping fdt memory node fixup Rob Herring
2013-01-25 3:39 ` [U-Boot] [PATCH 2/2] ARM: highbank: remove DRAM bank setup Rob Herring
2013-02-19 19:27 ` Wolfgang Denk [this message]
2013-02-19 16:35 ` [U-Boot] [PATCH 1/2] ARM: bootm: allow skipping fdt memory node fixup Tom Rini
2013-02-19 19:26 ` Wolfgang Denk
2013-02-19 20:39 ` Rob Herring
2013-02-19 23:14 ` Wolfgang Denk
2013-02-20 14:07 ` Rob Herring
2013-02-20 14:11 ` Wolfgang Denk
2013-02-20 14:33 ` Tom Rini
2013-02-20 21:55 ` Peter Korsgaard
2013-02-20 22:13 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219192723.75779200530@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.