From: Fengguang Wu <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chuansheng Liu <chuansheng.liu@intel.com>,
mingo@kernel.org, peterz@infradead.org, jbeulich@suse.com,
paulmck@linux.vnet.ibm.com, mina86@mina86.org,
srivatsa.bhat@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
jun.zhang@intel.com
Subject: Re: [PATCH V2] smp: Give WARN()ing when calling smp_call_function_many()/single() in serving irq
Date: Wed, 20 Feb 2013 09:06:43 +0800 [thread overview]
Message-ID: <20130220010643.GA7595@localhost> (raw)
In-Reply-To: <20130219150123.07024b5b.akpm@linux-foundation.org>
On Tue, Feb 19, 2013 at 03:01:23PM -0800, Andrew Morton wrote:
> On Mon, 18 Feb 2013 09:38:52 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
>
> > Chuansheng,
> >
> > It works fine on tip/next. Thanks for the fix!
> >
> > Tested-by: Fengguang Wu <fengguang.wu@intel.com>
>
> How did you test this? What did you do?
I used the same kconfig to build a kernel from tip/next HEAD *plus*
the v2 patch. The result is, no smp_call_function_single/many warnings
are observed.
> afacit the patch adds additional warnings, so you must have had some
> buggy code and with the patch, runtime warnings are generated which
> inform you of that bug?
Andrew, the background is: Ingo has *reverted* the original patch that
triggered the smp_call_function_single warning from his tip tree, so
the test result means this patch's warning messages won't trigger in
my test boots.
Thanks,
Fengguang
next prev parent reply other threads:[~2013-02-20 1:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 15:18 [PATCH] smp: give WARN in case of in_interrupt() when calling smp_call_function_many/single Chuansheng Liu
2013-02-06 13:42 ` [tip:core/locking] smp: Give WARN()ing if in_interrupt() when calling smp_call_function_many()/single() tip-bot for Chuansheng Liu
2013-02-11 12:20 ` [tip:core/locking] Revert "smp: Give WARN()ing if in_interrupt() when calling smp_call_function_many()/single()" tip-bot for Ingo Molnar
2013-02-16 5:26 ` Liu, Chuansheng
2013-02-16 13:57 ` [PATCH] smp: Give WARN()ing when calling smp_call_function_many()/single() in serving irq Chuansheng Liu
2013-02-16 14:10 ` [PATCH V2] " Chuansheng Liu
2013-02-18 1:38 ` Fengguang Wu
2013-02-19 23:01 ` Andrew Morton
2013-02-20 1:06 ` Fengguang Wu [this message]
2013-02-20 1:22 ` Liu, Chuansheng
2013-02-27 14:50 ` Lai Jiangshan
2013-03-01 3:37 ` Liu, Chuansheng
2013-08-05 22:46 ` Andrew Morton
2013-07-05 13:50 ` Thomas Gleixner
2013-07-05 14:37 ` Thomas Gleixner
2013-07-07 3:59 ` Wang YanQing
2013-07-07 13:47 ` Thomas Gleixner
2013-12-06 1:29 ` Max Filippov
2013-12-06 14:02 ` Thomas Gleixner
2013-12-06 18:31 ` Max Filippov
2013-07-07 2:41 ` Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220010643.GA7595@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=jbeulich@suse.com \
--cc=jun.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mina86@mina86.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.