From: Ingo Molnar <mingo@kernel.org>
To: Alex Shi <alex.shi@intel.com>
Cc: Michel Lespinasse <walken@google.com>,
linux-kernel@vger.kernel.org, anton@samba.org, hpa@zytor.com,
arjan@linux.intel.com, a.p.zijlstra@chello.nl,
torvalds@linux-foundation.org, yuanhan.liu@linux.intel.com,
dhowells@redhat.com, akpm@linux-foundation.org,
tglx@linutronix.de
Subject: Re: [PATCH 0/4] rwsem: Implement writer lock-stealing
Date: Wed, 20 Feb 2013 11:40:43 +0100 [thread overview]
Message-ID: <20130220104043.GB7691@gmail.com> (raw)
In-Reply-To: <51248E59.2010907@intel.com>
* Alex Shi <alex.shi@intel.com> wrote:
> > Alex, could you go through my patch and see if there is
> > anything you find objectionable ? (if not about the details,
> > at least about the general approach of enabling writer lock
> > stealing on the fast path)
>
> I did a quick review on the patchset and tested the patches
> 1~3, and 1~3 plus 4th, my patch plus 4th.
>
> The patch looks much complicated, and also goes writing slow
> path to steal locking. My patch looks quite straight and
> simple.
>
> This 1~3 patch has very very similar performance effect with
> mine.
>
> The highlight patch is the 4th, seems it can provide about ~2%
> aim7 performance gain(base on both of mine or patches 1~3) on
> my 4S NHM EX machine.
That speedup would be nice to have.
Thanks,
Ingo
next prev parent reply other threads:[~2013-02-20 10:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 2:45 [PATCH 0/4] rwsem: Implement writer lock-stealing Michel Lespinasse
2013-02-09 2:45 ` [PATCH 1/4] rwsem: make the waiter type an enumeration rather than a bitmask Michel Lespinasse
2013-02-09 2:45 ` [PATCH 2/4] rwsem: shorter spinlocked section in rwsem_down_failed_common() Michel Lespinasse
2013-02-09 2:45 ` [PATCH 3/4] rwsem: implement write lock stealing Michel Lespinasse
2013-02-09 7:30 ` Hillf Danton
2013-02-09 7:42 ` Michel Lespinasse
2013-02-09 13:11 ` Hillf Danton
2013-02-09 2:45 ` [PATCH 4/4] x86 rwsem: avoid taking slow path when stealing write lock Michel Lespinasse
2013-02-13 13:55 ` [PATCH 0/4] rwsem: Implement writer lock-stealing Alex Shi
2013-02-13 14:49 ` Ingo Molnar
2013-02-14 1:31 ` Michel Lespinasse
2013-02-14 12:08 ` Alex Shi
2013-02-20 8:50 ` Alex Shi
2013-02-20 10:40 ` Ingo Molnar [this message]
2013-02-20 16:50 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220104043.GB7691@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=anton@samba.org \
--cc=arjan@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.