Re: [PATCH 1/1] highbank: add wfi for poweroff - Jean-Christophe PLAGNIOL-VILLARD

From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Rob Herring <rob.herring@calxeda.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] highbank: add wfi for poweroff
Date: Wed, 20 Feb 2013 15:22:59 +0100	[thread overview]
Message-ID: <20130220142259.GA5291@game.jcrosoft.org> (raw)
In-Reply-To: <5124D92C.9030308@calxeda.com>

On 08:09 Wed 20 Feb     , Rob Herring wrote:
> On 02/20/2013 06:55 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > needed by the real hardware
> > 
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  arch/arm/mach-highbank/reset.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
> > index 630672a..b9664e4 100644
> > --- a/arch/arm/mach-highbank/reset.c
> > +++ b/arch/arm/mach-highbank/reset.c
> > @@ -23,5 +23,7 @@ void __noreturn poweroff()
> >  	shutdown_barebox();
> >  
> >  	hingbank_set_pwr_shutdown();
> > +	asm("	wfi");
> > +
> 
> This will break on old compilers or v5 builds. I personally don't care,
> but some people do.
I do not care too

and highbank is a v7 so I expect you use the proper compiler

Best Regards,
J.
> 
> Rob
> 
> >  	while(1);
> >  }
> > 
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox