From: Robin Holt <holt@sgi.com>
To: Armin Steinhoff <armin@steinhoff.de>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: io_apic.c --> "nr_ioapics" not initialized !
Date: Wed, 20 Feb 2013 15:04:14 -0600 [thread overview]
Message-ID: <20130220210414.GK3460@sgi.com> (raw)
In-Reply-To: <5124F7BA.5080905@steinhoff.de>
On Wed, Feb 20, 2013 at 05:20:10PM +0100, Armin Steinhoff wrote:
>
> Hello,
>
> after a walk through the module "io_apic.c" in
> "/usr/src/linux/arch/x86/kernel/apic" I got the impression that the
> variable "nr_ioapics" is used but isn't initialized !
Just to be sure we are looking at the same thing, it is declared in
arch/x86/kernel/apic/io_apic.c on line 129. Being declared that way,
it is, by definition, 0 unless there is an initializer.
Did I miss something?
Thanks,
Robin
> Could it be the source of boot problems ?
>
> Dangerous coding stile in "static struct resource * __init
> ioapic_setup_resources(int nr_ioapics)" ....
> ########
>
> Cheers
>
> --Armin
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-02-20 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 3:56 [PATCH RT 0/7] [ANNOUNCE] 3.2.38-rt58-rc1 stable review Steven Rostedt
2013-02-19 3:56 ` [PATCH RT 1/7] x86/32: Use kmap switch for non highmem as well Steven Rostedt
2013-02-19 3:56 ` [PATCH RT 2/7] acpi/rt: Convert acpi_gbl_hardware lock back to a raw_spinlock_t Steven Rostedt
2013-02-19 3:56 ` [PATCH RT 3/7] printk: Fix rq->lock vs logbuf_lock unlock lock inversion Steven Rostedt
2013-02-19 3:56 ` [PATCH RT 4/7] serial: Imx: Fix recursive locking bug Steven Rostedt
2013-02-19 3:56 ` [PATCH RT 5/7] wait-simple: Simple waitqueue implementation Steven Rostedt
2013-02-19 3:56 ` [PATCH RT 6/7] rcutiny: Use simple waitqueue Steven Rostedt
2013-02-20 16:20 ` io_apic.c --> "nr_ioapics" not initialized ! Armin Steinhoff
2013-02-20 21:04 ` Robin Holt [this message]
2013-02-20 22:55 ` Thomas Gleixner
2013-02-21 7:30 ` Armin Steinhoff
2013-02-19 3:56 ` [PATCH RT 7/7] Linux 3.2.38-rt58-rc1 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220210414.GK3460@sgi.com \
--to=holt@sgi.com \
--cc=armin@steinhoff.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.