From: Andrew Morton <akpm@linux-foundation.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] the ac->ac_allow_chain_relink=0 won't disable group relink
Date: Thu, 21 Feb 2013 14:15:07 -0800 [thread overview]
Message-ID: <20130221141507.c91be59d.akpm@linux-foundation.org> (raw)
In-Reply-To: <1361433259-15336-1-git-send-email-xiaowei.hu@oracle.com>
On Thu, 21 Feb 2013 15:54:19 +0800
xiaowei.hu at oracle.com wrote:
> ocfs2_block_group_alloc_discontig() disables chain relink by setting
> ac->ac_allow_chain_relink = 0 because it grabs clusters from multiple
> cluster groups. It doesn't keep the credits for all chain relink,but
> ocfs2_claim_suballoc_bits overrides this in this call trace:
> ocfs2_block_group_claim_bits()->ocfs2_claim_clusters()->
> __ocfs2_claim_clusters()->ocfs2_claim_suballoc_bits()
> ocfs2_claim_suballoc_bits set ac->ac_allow_chain_relink = 1; then call
> ocfs2_search_chain() one time and disable it again, and then we run
> out of credits.
>
> Fix is to allow relink by default and disable it in
> ocfs2_block_group_alloc_discontig.
What is the end-user impact of this bug?
Please always include this info in changelogs to help other to decide
which kernel version(s) need the patch, thanks.
next prev parent reply other threads:[~2013-02-21 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 7:54 [Ocfs2-devel] [PATCH] the ac->ac_allow_chain_relink=0 won't disable group relink xiaowei.hu at oracle.com
2013-02-21 22:15 ` Andrew Morton [this message]
2013-02-22 0:42 ` xiaowei.hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221141507.c91be59d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.