From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4 1/9] drm: Remove duplicate drm_mode_cea_vic() Date: Thu, 21 Feb 2013 17:04:31 +0200 Message-ID: <20130221150431.GG4469@intel.com> References: <1361458218-14464-1-git-send-email-thierry.reding@avionic-design.de> <1361458218-14464-2-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B493E5F49 for ; Thu, 21 Feb 2013 07:05:23 -0800 (PST) Content-Disposition: inline In-Reply-To: <1361458218-14464-2-git-send-email-thierry.reding@avionic-design.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Thierry Reding Cc: Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Feb 21, 2013 at 03:50:10PM +0100, Thierry Reding wrote: > The same function had already been merged with a different name. Remove > the duplicate one but reuse some of its kerneldoc fragments for the > existing implementation. We have a few more uses of this in i915 since my RGB quant range stuff got merged. > = > Signed-off-by: Thierry Reding > --- > Changes in v4: > - replace drm_mode_cea_vic() usage in i915 HDMI code > - move to front of patch series > = > drivers/gpu/drm/drm_edid.c | 30 +++++++----------------------- > drivers/gpu/drm/i915/intel_hdmi.c | 2 +- > include/drm/drm_crtc.h | 3 +-- > 3 files changed, 9 insertions(+), 26 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 67aa0dd..02da919 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -1516,11 +1516,14 @@ u8 *drm_find_cea_extension(struct edid *edid) > } > EXPORT_SYMBOL(drm_find_cea_extension); > = > -/* > - * Looks for a CEA mode matching given drm_display_mode. > - * Returns its CEA Video ID code, or 0 if not found. > +/** > + * drm_match_cea_mode - look for a CEA mode matching given mode > + * @to_match: display mode > + * > + * Returns the CEA Video ID (VIC) of the mode or 0 if it isn't a CEA-861 > + * mode. > */ > -u8 drm_match_cea_mode(struct drm_display_mode *to_match) > +u8 drm_match_cea_mode(const struct drm_display_mode *to_match) > { > struct drm_display_mode *cea_mode; > u8 mode; > @@ -2114,22 +2117,3 @@ int drm_add_modes_noedid(struct drm_connector *con= nector, > return num_modes; > } > EXPORT_SYMBOL(drm_add_modes_noedid); > - > -/** > - * drm_mode_cea_vic - return the CEA-861 VIC of a given mode > - * @mode: mode > - * > - * RETURNS: > - * The VIC number, 0 in case it's not a CEA-861 mode. > - */ > -uint8_t drm_mode_cea_vic(const struct drm_display_mode *mode) > -{ > - uint8_t i; > - > - for (i =3D 0; i < drm_num_cea_modes; i++) > - if (drm_mode_equal(mode, &edid_cea_modes[i])) > - return i + 1; > - > - return 0; > -} > -EXPORT_SYMBOL(drm_mode_cea_vic); > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/int= el_hdmi.c > index 3ea0c8b..75d5152 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -348,7 +348,7 @@ static void intel_hdmi_set_avi_infoframe(struct drm_e= ncoder *encoder, > avi_if.body.avi.ITC_EC_Q_SC |=3D DIP_AVI_RGB_QUANT_RANGE_FULL; > } > = > - avi_if.body.avi.VIC =3D drm_mode_cea_vic(adjusted_mode); > + avi_if.body.avi.VIC =3D drm_match_cea_mode(adjusted_mode); > = > intel_set_infoframe(encoder, &avi_if); > } > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 8b77627..7762718 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -1061,7 +1061,7 @@ extern int drm_mode_gamma_get_ioctl(struct drm_devi= ce *dev, > extern int drm_mode_gamma_set_ioctl(struct drm_device *dev, > void *data, struct drm_file *file_priv); > extern u8 *drm_find_cea_extension(struct edid *edid); > -extern u8 drm_match_cea_mode(struct drm_display_mode *to_match); > +extern u8 drm_match_cea_mode(const struct drm_display_mode *to_match); > extern bool drm_detect_hdmi_monitor(struct edid *edid); > extern bool drm_detect_monitor_audio(struct edid *edid); > extern bool drm_rgb_quant_range_selectable(struct edid *edid); > @@ -1079,7 +1079,6 @@ extern struct drm_display_mode *drm_gtf_mode_comple= x(struct drm_device *dev, > int GTF_2C, int GTF_K, int GTF_2J); > extern int drm_add_modes_noedid(struct drm_connector *connector, > int hdisplay, int vdisplay); > -extern uint8_t drm_mode_cea_vic(const struct drm_display_mode *mode); > = > extern int drm_edid_header_is_valid(const u8 *raw_edid); > extern bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad= _edid); > -- = > 1.8.1.2 -- = Ville Syrj=E4l=E4 Intel OTC