From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH] drm/i915: Handle untiled planes when computing their offsets Date: Thu, 21 Feb 2013 22:17:37 +0200 Message-ID: <20130221201737.GJ4469@intel.com> References: <20130221195441.GI4469@intel.com> <1361477071-9914-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1361477071-9914-1-git-send-email-chris@chris-wilson.co.uk> Sender: stable-owner@vger.kernel.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Feb 21, 2013 at 08:04:31PM +0000, Chris Wilson wrote: > We trim the fb to fit the CRTC by computing the offset of that CRTC t= o > its nearest tile_row origin. This allows us to use framebuffers that = are > larger than the CRTC limits without additional work. >=20 > However, we failed to compute the offset for a linear framebuffer > correctly as we treated its x-advance in whole tiles (instead of the > linear increment expected), leaving the CRTC misaligned with its > contents. >=20 > Fixes regression from commit c2c75131244507c93f812862fdbd4f3a37139401 > Author: Daniel Vetter > Date: Thu Jul 5 12:17:30 2012 +0200 >=20 > drm/i915: adjust framebuffer base address on gen4+ >=20 > v2: Adjust relative x-coordinate after linear alignment (vsyrjala) > v3: Repaint with pokadots (vsyrjala) >=20 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D61152 > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: stable@vger.kernel.org Looking good. Reviewed-by: Ville Syrj=E4l=E4 --=20 Ville Syrj=E4l=E4 Intel OTC