From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755118Ab3BVBdG (ORCPT ); Thu, 21 Feb 2013 20:33:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29350 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753513Ab3BVBdB (ORCPT ); Thu, 21 Feb 2013 20:33:01 -0500 Date: Thu, 21 Feb 2013 20:26:01 -0300 From: Marcelo Tosatti To: Ingo Molnar Cc: Shuah Khan , dan.carpenter@oracle.com, peterz@infradead.org, Linux Kernel Mailing List , torvalds@linux-foundation.org Subject: Re: sched: Fix signedness bug in yield_to() Message-ID: <20130221232600.GA21754@amt.cnet> References: <20130220022712.0E8586607A4@gitolite.kernel.org> <20130221085654.GB23223@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130221085654.GB23223@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 21, 2013 at 09:56:54AM +0100, Ingo Molnar wrote: > > * Shuah Khan wrote: > > > On Tue, Feb 19, 2013 at 7:27 PM, Linux Kernel Mailing List > > wrote: > > > Gitweb: http://git.kernel.org/linus/;a=commit;h=c3c186403c6abd32e719f005f0af950155a9e54d > > > Commit: c3c186403c6abd32e719f005f0af950155a9e54d > > > Parent: e0a79f529d5ba2507486d498b25da40911d95cf6 > > > Author: Dan Carpenter > > > AuthorDate: Tue Feb 5 14:37:51 2013 +0300 > > > Committer: Ingo Molnar > > > CommitDate: Tue Feb 5 12:59:29 2013 +0100 > > > > > > sched: Fix signedness bug in yield_to() > > > > > > In 7b270f6099 "sched: Bail out of yield_to when source and > > > target runqueue has one task" we changed this to store -ESRCH so > > > it needs to be signed. > > > > Dan, Ingo, > > > > I can't find the 7b270f6099 "sched: Bail out of yield_to when > > source and target runqueue has one task" in the latest Linus's > > git. Am I missing something. > > > > The current kenel/sched/core.c doesn't have the code from the > > associated patch https://patchwork.kernel.org/patch/2016651/ > > As per the lkml discussion that one was supposed to go upstream > via the KVM tree. Marcelo? commit c3c186403c6abd32e719f005f0af950155a9e54d Author: Dan Carpenter Date: Tue Feb 5 14:37:51 2013 +0300 sched: Fix signedness bug in yield_to() In 7b270f6099 "sched: Bail out of yield_to when source and target runqueue has one task" we changed this to store -ESRCH so it needs to be signed. Signed-off-by: Dan Carpenter Cc: Peter Zijlstra Cc: kbuild@01.org Cc: Steven Rostedt Cc: Mike Galbraith Link: http://lkml.kernel.org/r/20130205113751.GA20521@elgon.mountain Signed-off-by: Ingo Molnar