From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix free clusters calculation in bigalloc filesystem
Date: Fri, 22 Feb 2013 00:10:48 -0500 [thread overview]
Message-ID: <20130222051048.GC13667@thunk.org> (raw)
In-Reply-To: <1361433665-16880-1-git-send-email-lczerner@redhat.com>
On Thu, Feb 21, 2013 at 09:01:05AM +0100, Lukas Czerner wrote:
>
> Moreover when calculating number of root clusters we should be using
> macro EXT4_NUM_B2C() instead of EXT4_C2B() otherwise the result will
> usually be off by one.
That should be "instead of EXT4_B2C()", and I don't think this is
true, since the number of blocks should always be a multiple of the
cluster ratio. So the use of EXT4_B2C() is a bit of an optimization
(it avoids an add and mask operation), but it's probably not a
measurable optimizatoin in practice.
- Ted
next prev parent reply other threads:[~2013-02-22 5:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 8:01 [PATCH] ext4: fix free clusters calculation in bigalloc filesystem Lukas Czerner
2013-02-21 12:15 ` [PATCH] ext4: fix overhead calculation in bigalloc filesystem (Re: ... ) Zheng Liu
2013-02-21 12:40 ` Lukáš Czerner
2013-02-21 12:50 ` Lukáš Czerner
2013-02-21 12:52 ` Lukáš Czerner
2013-02-21 13:49 ` Zheng Liu
2013-02-21 14:56 ` Lukáš Czerner
2013-02-22 3:03 ` Zheng Liu
2013-02-22 4:05 ` Theodore Ts'o
2013-02-22 8:04 ` Lukáš Czerner
2013-02-22 13:18 ` Zheng Liu
2013-02-22 15:20 ` Theodore Ts'o
2013-02-22 16:26 ` Zheng Liu
2013-03-24 12:29 ` [PATCH] ext4: fold ext4_generic_write_end into ext4_write_end Zheng Liu
2013-03-25 0:07 ` Theodore Ts'o
2013-02-21 13:12 ` [PATCH] ext4: fix overhead calculation in bigalloc filesystem (Re: ... ) Zheng Liu
2013-02-22 5:10 ` Theodore Ts'o [this message]
2013-02-22 7:57 ` [PATCH] ext4: fix free clusters calculation in bigalloc filesystem Lukáš Czerner
2013-02-22 8:39 ` [PATCH v2] " Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222051048.GC13667@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.