From: Thierry Reding <thierry.reding@avionic-design.de>
To: Dong Aisheng <b29396@freescale.com>
Cc: Alexander Shiyan <shc_work@mail.ru>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Dong Aisheng <dong.aisheng@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v4] mfd: syscon: Add non-DT support
Date: Fri, 22 Feb 2013 10:24:29 +0100 [thread overview]
Message-ID: <20130222092428.GA27937@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20130222092055.GF3252@b29396-Latitude-E6410>
[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]
On Fri, Feb 22, 2013 at 05:20:56PM +0800, Dong Aisheng wrote:
> On Fri, Feb 22, 2013 at 09:52:12AM +0100, Thierry Reding wrote:
> > On Fri, Feb 22, 2013 at 04:29:55PM +0800, Dong Aisheng wrote:
> > > On Fri, Feb 22, 2013 at 08:27:19AM +0100, Thierry Reding wrote:
> > > ...
> > > > > > > Otherwise, i'm also ok with this patch.
> > > > > > > Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
> > > > > > >
> > > > > > > BTW, i did not see Samuel's tree having this new API.
> > > > > > > So, who will pick this patch?
> > > > > >
> > > > > > I have same question.
> > > > >
> > > > > I CCed Thierry and Greg who may know it.
> > > >
> > > > Yes, devm_ioremap_resource() never returns NULL. You always need to
> > > > check the returned pointer with IS_ERR(). The value that you return
> > > > should be extracted from the pointer with PTR_ERR().
> > >
> > > Thanks Thierry.
> > > Since Samuel's mdf tree does not have your patch introducing
> > > the new API of devm_ioremap_resource,
> > > do you know which tree this patch can go through, Greg's driver core tree?
> >
> > I don't think it matters much at this point because Linus merged the
> > driver core tree yesterday, so anything that gets applied now should
> > automatically have the new API available.
> >
> I just tried update to latest linus tree, still did not find this API defined
> in include/linux/io.h.
> Would you mind point it out for me?
Commit 75096579c3ac39ddc2f8b0d9a8924eba31f4d920 introduced it. The
prototype is in include/linux/device.h and the implementation in
lib/devres.c.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-22 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 15:29 [PATCH v4] mfd: syscon: Add non-DT support Alexander Shiyan
2013-02-21 16:18 ` [PATCH v4] mfd: syscon: Add non-DT suppor Arnd Bergmann
2013-02-22 6:55 ` [PATCH v4] mfd: syscon: Add non-DT support Dong Aisheng
2013-02-22 7:01 ` Re[2]: " Alexander Shiyan
2013-02-22 7:13 ` Dong Aisheng
2013-02-22 7:27 ` Thierry Reding
2013-02-22 8:29 ` Dong Aisheng
2013-02-22 8:52 ` Thierry Reding
2013-02-22 9:20 ` Dong Aisheng
2013-02-22 9:24 ` Thierry Reding [this message]
2013-02-22 9:31 ` Dong Aisheng
2013-02-23 5:10 ` Re[2]: " Alexander Shiyan
2013-02-22 9:11 ` Arnd Bergmann
2013-02-22 9:19 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222092428.GA27937@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=arnd@arndb.de \
--cc=b29396@freescale.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dong.aisheng@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.