All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: randconfig errors
Date: Fri, 22 Feb 2013 09:29:08 +0000	[thread overview]
Message-ID: <201302220929.08736.arnd@arndb.de> (raw)
In-Reply-To: <511E9A73.4090806@boundarydevices.com>

On Friday 15 February 2013, Troy Kisky wrote:
> > Commit 7248001, "clk: vt8500: Fix device clock divisor calculations"
> > introduced logic to improve divider selection while changing rates for
> > the VT8500 dclk.  However a copy-paste error results in using the wrong
> > variable name in the .set_rate callback.  Fixed by changing *prate to
> > parent_rate.  The .round_rate function is correct and remains unchanged.
> >
> > Signed-off-by: Mike Turquette <mturquette@linaro.org>
> > Cc: Tony Prisk <linux@prisktech.co.nz>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Rob Herring <robherring2@gmail.com>
> > ---
> >   drivers/clk/clk-vt8500.c |    4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
> > index b5538bb..c010861 100644
> > --- a/drivers/clk/clk-vt8500.c
> > +++ b/drivers/clk/clk-vt8500.c
> > @@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
> >   
> >       divisor =  parent_rate / rate;
> >   
> > -     /* If prate / rate would be decimal, incr the divisor */
> > -     if (rate * divisor < *prate)
> > +     /* If parent_rate / rate would be decimal, incr the divisor */
> > +     if (rate * divisor < parent_rate)
> >               divisor++;
> >   
> >       if (divisor == cdev->div_mask + 1)
> What about just
> 
>          divisor = (parent_rate + rate - 1) / rate;
> 

This is now broken in Linus' upstream tree. Could you get one fix merged?

	Arnd

  reply	other threads:[~2013-02-22  9:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 17:25 randconfig errors Rob Herring
2013-02-15 18:00 ` Arnd Bergmann
2013-02-15 20:11   ` Mike Turquette
2013-02-15 20:28     ` Troy Kisky
2013-02-22  9:29       ` Arnd Bergmann [this message]
2013-02-15 18:22 ` Marc Zyngier
2013-02-15 18:47   ` Marc Zyngier
2013-02-15 19:16     ` Christoffer Dall
2013-02-15 19:22       ` Marc Zyngier
2013-02-15 19:24         ` Christoffer Dall
2013-02-15 19:24           ` Christoffer Dall
     [not found] ` <c01a8ed845054b9d9cbddb341bac5f0e@DLEE74.ent.ti.com>
2013-02-15 19:45   ` Matt Porter
2013-02-15 20:12     ` Arnd Bergmann
2013-02-15 20:25       ` Chris Ball
2013-02-20  6:36       ` Vinod Koul
2013-02-20  9:53         ` Arnd Bergmann
2013-02-21 10:38 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302220929.08736.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.