From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH -next] spi: fix return value check in ce4100_spi_probe() Date: Fri, 22 Feb 2013 11:33:07 +0200 Message-ID: <20130222093307.GH2439@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Wei Yongjun Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, Feb 22, 2013 at 10:52:35AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function platform_device_register_full() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Nice catch! Acked-by: Mika Westerberg ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755721Ab3BVJ3B (ORCPT ); Fri, 22 Feb 2013 04:29:01 -0500 Received: from mga09.intel.com ([134.134.136.24]:25138 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754205Ab3BVJ25 (ORCPT ); Fri, 22 Feb 2013 04:28:57 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,714,1355126400"; d="scan'208";a="266136170" Date: Fri, 22 Feb 2013 11:33:07 +0200 From: Mika Westerberg To: Wei Yongjun Cc: eric.y.miao@gmail.com, linux@arm.linux.org.uk, haojian.zhuang@gmail.com, grant.likely@secretlab.ca, broonie@opensource.wolfsonmicro.com, yongjun_wei@trendmicro.com.cn, linux-arm-kernel@lists.infradead.org, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] spi: fix return value check in ce4100_spi_probe() Message-ID: <20130222093307.GH2439@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 22, 2013 at 10:52:35AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function platform_device_register_full() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Nice catch! Acked-by: Mika Westerberg