From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 03/10] drm/i915: add pipe_config->timings_set Date: Fri, 22 Feb 2013 15:51:15 +0200 Message-ID: <20130222135115.GN4469@intel.com> References: <1361491014-13888-1-git-send-email-daniel.vetter@ffwll.ch> <1361491014-13888-4-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 03457E5EEF for ; Fri, 22 Feb 2013 05:51:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <1361491014-13888-4-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Fri, Feb 22, 2013 at 12:56:47AM +0100, Daniel Vetter wrote: > Only used by the lvds encoder. Note that we shouldn't do the same > simple conversion with the FORCE_6BPC flag, since that's much better > handled by moving all the pipe_bpc computation around. > = > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 12 +++++++++++- > drivers/gpu/drm/i915/intel_drv.h | 10 ++++++---- > drivers/gpu/drm/i915/intel_lvds.c | 19 +++++++++---------- > 3 files changed, 26 insertions(+), 15 deletions(-) > = > @@ -359,6 +357,7 @@ static bool intel_lvds_mode_fixup(struct drm_encoder = *encoder, > I915_WRITE(BCLRPAT(pipe), 0); > = > drm_mode_set_crtcinfo(adjusted_mode, 0); > + pipe_config->timings_set =3D true; This changes the behaviour a bit. Previously the flag was only set from the centering funcs, but now it's set always. Is that intentional? > = > switch (intel_connector->panel.fitting_mode) { > case DRM_MODE_SCALE_CENTER: > @@ -661,7 +660,6 @@ static int intel_lvds_set_property(struct drm_connect= or *connector, > } > = > static const struct drm_encoder_helper_funcs intel_lvds_helper_funcs =3D= { > - .mode_fixup =3D intel_lvds_mode_fixup, > .mode_set =3D intel_lvds_mode_set, > }; > = > @@ -1102,6 +1100,7 @@ bool intel_lvds_init(struct drm_device *dev) > intel_encoder->enable =3D intel_enable_lvds; > intel_encoder->pre_enable =3D intel_pre_enable_lvds; > intel_encoder->pre_pll_enable =3D intel_pre_pll_enable_lvds; > + intel_encoder->compute_config =3D intel_lvds_compute_config; > intel_encoder->disable =3D intel_disable_lvds; > intel_encoder->get_hw_state =3D intel_lvds_get_hw_state; > intel_connector->get_hw_state =3D intel_connector_get_hw_state; > -- = > 1.7.11.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC