Re: [PATCH 07/14] Bluetooth: Add transaction cmd_complete and cmd_status functions

[Vinicius Costa Gomes <vinicius.gomes@openbossa.org>]

On 15:12 Fri 22 Feb, Johan Hedberg wrote:
> From: Johan Hedberg <johan.hedberg@intel.com>
> 
> This patch introduces functions to process the transaction state when
> receiving HCI Command Status or Command Complete events. Some HCI
> commands, like Inquiry do not result in a Command complete event so
> special handling is needed for them. Inquiry is a particularly important
> one since it is the only forseeable "non-cmd_complete" command that will
> make good use of the transaction framework, and its completion is either
> indicated by an Inquiry Complete event of a successful Command Complete
> for HCI_Inquiry_Cancel.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---

Looking pretty good.

[snip]

> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 14e872a..6dd5fd4 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -53,6 +53,7 @@ static void hci_cc_inquiry_cancel(struct hci_dev *hdev, struct sk_buff *skb)
>  	hci_discovery_set_state(hdev, DISCOVERY_STOPPED);
>  	hci_dev_unlock(hdev);
>  
> +	hci_transaction_cmd_complete(hdev, HCI_OP_INQUIRY, status);
>  	hci_req_complete(hdev, HCI_OP_INQUIRY_CANCEL, status);
>  
>  	hci_conn_check_pending(hdev);
> @@ -1692,6 +1693,7 @@ static void hci_inquiry_complete_evt(struct hci_dev *hdev, struct sk_buff *skb)
>  
>  	BT_DBG("%s status 0x%2.2x", hdev->name, status);
>  
> +	hci_transaction_cmd_complete(hdev, HCI_OP_INQUIRY, status);

There are quite a few other commands that do not cause a Command Complete
event, for example, LE Start Encryption, causes either a Encrypt Change or a
Key Refresh; LE Create Connection, causes a Connection Complete.

So if I want to add support for these commands to be part of a transaction I
would need to add the appropriate handler to the associated "complete" events,
right?  I feel that I already know the answer ;-) This question is more about
others developers losing time thinking: "Why transactions doesn't work for
these particular commands?".


Cheers,
-- 
Vinicius