From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 2 of 7] tools/xc: handle tty output differently in stdiostream_progress Date: Fri, 22 Feb 2013 18:06:42 +0100 Message-ID: <20130222170642.GA25362@aepfle.de> References: <1518e1b1341a56e8ea52.1360770780@probook.site> <20775.42298.906250.582926@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20775.42298.906250.582926@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Feb 22, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH 2 of 7] tools/xc: handle tty output differently in stdiostream_progress"): > > tools/xc: handle tty output differently in stdiostream_progress > > > > If the output goes to a tty, rewind the cursor and print everything in a > > single line as it was done up to now. If the output goes to a file or > > pipe print a newline after each progress output. This will fix logging > > of progress messages from xc_save to xend.log. > > > > To support XTL_STDIOSTREAM_SHOW_PID or XTL_STDIOSTREAM_SHOW_DATE print > > the output via vmessage if the output is not a tty. > > Can we lift the call to isatty out of the loop by calling it at > setup ? > > Calling it continually is undesirable not really for performance > reasons but because it always trashes errno and because it will make > strace output more noisy. Ok, I will prepare a patch. I think that series is already applied. Olaf