From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-da0-f48.google.com ([209.85.210.48]:50225 "EHLO mail-da0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756752Ab3BWOkH (ORCPT ); Sat, 23 Feb 2013 09:40:07 -0500 Received: by mail-da0-f48.google.com with SMTP id w4so802380dam.35 for ; Sat, 23 Feb 2013 06:40:06 -0800 (PST) Date: Sat, 23 Feb 2013 06:40:47 -0800 From: Greg KH To: Takahisa Tanaka Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck , Paul Menzel , Arkadiusz Miskiewicz , Bjorn Helgaas , Andrew Morton , Jonathan Nieder , linux-kernel@vger.kernel.org, Florian Mickler , Joseph Salisbury , Joseph Salisbury , stable@vger.kernel.org Subject: Re: [PATCH] sp5100_tco: Remove code that may cause a boot failure Message-ID: <20130223144047.GA29325@kroah.com> References: <1361619112-7481-1-git-send-email-mc74hc00@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1361619112-7481-1-git-send-email-mc74hc00@gmail.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Sat, Feb 23, 2013 at 08:31:52PM +0900, Takahisa Tanaka wrote: > The critical problem which can't boot OS until the power is completely > cut off found on PC with SB700 chipset. This patch fix the problem, but, > this patch prevents the sp5100_tco driver from using watchdog timer > function of chipset on PC with SP5100 or SB7x0 chipset. > > Re-programming the MMIO address registers for the watchdog timer must > have generated the problem. However, I don't know root cause so far. > So, I decided to remove the concerned codes. > > Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1116835 > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43176 > > Signed-off-by: Takahisa Tanaka > --- > drivers/watchdog/sp5100_tco.c | 140 ++++-------------------------------------- > drivers/watchdog/sp5100_tco.h | 2 +- > 2 files changed, 14 insertions(+), 128 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.