From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, linux-ext4@vger.kernel.org
Subject: Re: ext4 xfstest regression due to ext4_es_lookup_extent
Date: Sat, 23 Feb 2013 19:14:47 -0500 [thread overview]
Message-ID: <20130224001447.GB1196@thunk.org> (raw)
In-Reply-To: <51289343.90704@gmail.com>
On Sat, Feb 23, 2013 at 06:00:35PM +0800, Zheng Liu wrote:
> > Actually I think that the regression in 269'th you have found recently
> > caused by similar issue and commit which you foud by bisecting ( the one
> > which allow migration between indirect<->extent based inodes)
> > simply helps to spot real issue in es_caching code.
>
> I will revise this patch. IIRC, we forgot to update status tree after
> an inode is migrated from extent-based to indirect-based. Thanks for
> pointing out.
Can you do this as a new commit? I've already bumped the master
pointer up since I finished running xfstests and I'm seeing no
regressions (at least with my set of xfstests). So given that
everything has been tested and things looks pretty stable, I pushed up
the master branch.
I did remember that you were still working on this regression, but
since we're already half-way through the merge window, I really want
to make things are ready for a merge request to Linus. (Which I
probably will be sending to Linus by Monday or Tuesday.)
I do plan to collect bug fixes and any remaining regression fixes to
push to Linus by -rc2 or -rc3, so if don't rush fixing up defrag
functionality.
Thanks!!
- Ted
next prev parent reply other threads:[~2013-02-24 0:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 17:17 ext4 xfstest regression due to ext4_es_lookup_extent Dmitry Monakhov
2013-02-22 18:03 ` Theodore Ts'o
2013-02-23 9:37 ` Dmitry Monakhov
2013-02-23 10:00 ` Zheng Liu
2013-02-24 0:14 ` Theodore Ts'o [this message]
2013-02-24 3:21 ` Zheng Liu
2013-02-26 23:18 ` [PATCH] jbd2: Fix ERR_PTR dereference in jbd2__journal_start Dmitry Monakhov
2013-03-02 22:10 ` Theodore Ts'o
2013-02-23 5:36 ` ext4 xfstest regression due to ext4_es_lookup_extent Zheng Liu
2013-02-24 14:58 ` Zheng Liu
2013-02-25 8:39 ` Dmitry Monakhov
2013-02-25 9:57 ` Zheng Liu
2013-02-26 20:06 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130224001447.GB1196@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.