From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alessandro Zummo Subject: Re: [RFE PATCH 2/2] rtc, add write functionality to sysfs Date: Mon, 25 Feb 2013 15:58:12 +0100 Message-ID: <20130225155812.0758e093@linux.lan.towertech.it> References: <1360861375-24131-1-git-send-email-prarit@redhat.com> <1360861375-24131-3-git-send-email-prarit@redhat.com> <5127D884.6020701@linaro.org> <5127DB2B.3030700@redhat.com> <5127DDAF.2000403@linaro.org> <512A47C5.3010500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <512A47C5.3010500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Prarit Bhargava Cc: John Stultz , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Thomas Gleixner , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Matt Fleming , David Vrabel , Andrew Morton , Andi Kleen , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Sun, 24 Feb 2013 12:03:01 -0500 Prarit Bhargava wrote: > > AFAICT there is no way for me to "test" or use the write from userspace. > hwclock uses the SET_TIME ioctl, which is a different code path AFAICT. > > I'd like to be at least able to test this stuff when we make changes to it so I > think having write functionality for date & time is worthwhile. > > For me, I'm using these to heavily test ntp and ntpdate over system reboots. the point is: who will benefit from this patch? users? distributions? embedded distributions? if it's useful, then just go for it. > OOC, Alessandro, why is the date & time split into two fields? because date and time are two different things and we expect sysfs to preferably have one value for each entry. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759740Ab3BYO6U (ORCPT ); Mon, 25 Feb 2013 09:58:20 -0500 Received: from zabrina.hetzner-de.towertech.it ([178.63.16.19]:41478 "EHLO zabrina.hetzner-de.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661Ab3BYO6R (ORCPT ); Mon, 25 Feb 2013 09:58:17 -0500 Date: Mon, 25 Feb 2013 15:58:12 +0100 From: Alessandro Zummo To: Prarit Bhargava Cc: John Stultz , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "x86@kernel.org" , Matt Fleming , David Vrabel , Andrew Morton , Andi Kleen , "linux-efi@vger.kernel.org" , "rtc-linux@googlegroups.com" Subject: Re: [RFE PATCH 2/2] rtc, add write functionality to sysfs Message-ID: <20130225155812.0758e093@linux.lan.towertech.it> In-Reply-To: <512A47C5.3010500@redhat.com> References: <1360861375-24131-1-git-send-email-prarit@redhat.com> <1360861375-24131-3-git-send-email-prarit@redhat.com> <5127D884.6020701@linaro.org> <5127DB2B.3030700@redhat.com> <5127DDAF.2000403@linaro.org> <512A47C5.3010500@redhat.com> Organization: Tower Technologies X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 24 Feb 2013 12:03:01 -0500 Prarit Bhargava wrote: > > AFAICT there is no way for me to "test" or use the write from userspace. > hwclock uses the SET_TIME ioctl, which is a different code path AFAICT. > > I'd like to be at least able to test this stuff when we make changes to it so I > think having write functionality for date & time is worthwhile. > > For me, I'm using these to heavily test ntp and ntpdate over system reboots. the point is: who will benefit from this patch? users? distributions? embedded distributions? if it's useful, then just go for it. > OOC, Alessandro, why is the date & time split into two fields? because date and time are two different things and we expect sysfs to preferably have one value for each entry. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it