From: Artem Savkov <artem.savkov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org, ibm-acpi@hmh.eng.br,
matthew.garrett@nebula.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()
Date: Tue, 26 Feb 2013 09:47:38 +0400 [thread overview]
Message-ID: <20130226054738.GA4191@thinkpad.lan> (raw)
In-Reply-To: <20130225155445.d3eef1ad.akpm@linux-foundation.org>
On Mon, Feb 25, 2013 at 03:54:45PM -0800, Andrew Morton wrote:
> On Sun, 24 Feb 2013 13:22:02 +0400
> Artem Savkov <artem.savkov@gmail.com> wrote:
>
> > set_freezable() checks freezing during which no locks should be held.
> > hotkey_thread_mutex lock should be moved closer to where it is actually needed.
> >
>
> Thanks.
>
> When fixing a bug, we always like to see a full description of that bug
> so we can better work out which kernel versions need the fix.
Sorry, will do thah in future.
> Did you actually hit a lockup because of this? Or was it just from
> code inspection? Or ... ?
I didn't hit an actual lockup, but I did hit a warning during boot. The
warning was added by "lockdep: check that no locks held at freeze time"
patch (2f2ff7b8979c50491b3cbce622d7bea4d44a8682 in linux-next.git)
--
Kind regards,
Artem
prev parent reply other threads:[~2013-02-26 5:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 9:22 [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable() Artem Savkov
2013-02-25 23:54 ` Andrew Morton
2013-02-26 5:47 ` Artem Savkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226054738.GA4191@thinkpad.lan \
--to=artem.savkov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.