All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Steigerwald <Martin@lichtvoll.de>
To: linux-btrfs@vger.kernel.org
Cc: "Zach Brown" <zab@redhat.com>,
	"Goffredo Baroncelli" <goffredo.baroncelli@yahoo.com>,
	"Hugo Mills" <hugo@carfax.org.uk>,
	"Michael Kjörling" <michael@kjorling.se>,
	cwillu <cwillu@cwillu.com>,
	"Chris Murphy" <lists@colorremedies.com>,
	"David Sterba" <dsterba@suse.cz>
Subject: Re: [PATCH V2][BTRFS-PROGS] Enhance btrfs fi df with raid5/6 support
Date: Tue, 26 Feb 2013 12:09:53 +0100	[thread overview]
Message-ID: <201302261209.54617.Martin@lichtvoll.de> (raw)
In-Reply-To: <20130225173808.GH22221@lenny.home.zabbo.net>

Am Montag, 25. Februar 2013 schrieb Zach Brown:
> > I updates my previous patches [1] to add support for raid5/6.
> > These patches update the btrfs fi df command and add two new commands:
> > - btrfs filesystem disk-usage <path>
> > - btrfs device disk-usage <path>
> 
> This seems like a ton of code.
> 
> Here's a thought experiment: What's the smallest possible change that
> could communicate the information that people don't have today?

The kind and amount of information output of these additions have been 
discussed several times before.

I found the output provided quite useful. As others.

Free space seems to be a complex matter in BTRFS and one conclusion was that 
its not easily possible to provide a single number to show how much space is 
free.

I´d still like that for df, whose output is quite bogus in certain BTRFS 
setups at the moment and does not give applications a realistic estimate at 
all. One example is raid 1 with 10 GB each disk. Shows 20 GB free. An 
application which wants to write 15 GB will fail. Which can break installer 
scripts, package management, cache software or anything else which checks 
for free space. Thus I´d like df to default to *minimum* free.

But what is it concretely, what you feel uncomfortable with? The Linux 
kernel is also a ton of code.

I´d really like to see Goffredo improvements go in instead of them being 
discussed endlessly. So I´d like to feedback to be as concrete as possible, 
so Goffredo has a chance to work on it.

Ciao,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7

  reply	other threads:[~2013-02-26 11:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-23 13:46 [PATCH V2][BTRFS-PROGS] Enhance btrfs fi df with raid5/6 support Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 1/8] Add some helpers to manage the strings allocation/deallocation Goffredo Baroncelli
2013-02-25  2:20   ` Eric Sandeen
2013-02-25 19:59     ` Goffredo Baroncelli
2013-02-25 20:19       ` Zach Brown
2013-02-25 21:00         ` Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 2/8] Enhance the command btrfs filesystem df Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 3/8] Create the man page entry for the command btrfs fi df Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 4/8] Add helpers functions to handle the printing of data in tabular format Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 5/8] Add command btrfs filesystem disk-usage Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 6/8] Create entry in man page for " Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 7/8] Add btrfs device disk-usage command Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 8/8] Create a new entry in btrfs man page for btrfs device disk-usage Goffredo Baroncelli
2013-02-25 17:38 ` [PATCH V2][BTRFS-PROGS] Enhance btrfs fi df with raid5/6 support Zach Brown
2013-02-26 11:09   ` Martin Steigerwald [this message]
2013-02-26 11:28     ` Gareth Pye
2013-02-26 12:58       ` Martin Steigerwald
2013-02-26 13:15         ` Martin Steigerwald
2013-02-26 12:55 ` Martin Steigerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302261209.54617.Martin@lichtvoll.de \
    --to=martin@lichtvoll.de \
    --cc=cwillu@cwillu.com \
    --cc=dsterba@suse.cz \
    --cc=goffredo.baroncelli@yahoo.com \
    --cc=hugo@carfax.org.uk \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    --cc=michael@kjorling.se \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.