All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Harvey <charvey@matrox.com>
To: dri-devel@lists.freedesktop.org
Cc: Julia Lemire <jlemire@matrox.com>,
	Mathieu Larouche <mathieu.larouche@matrox.com>
Subject: [PATCH] mgag200: some cleanup and a fix for corrupted output
Date: Tue, 26 Feb 2013 10:52:55 -0500	[thread overview]
Message-ID: <20130226155255.GA18595@harvey-pc.matrox.com> (raw)

Patches 1 to 4 are just cleanup. Maybe these should should be rolled
into one patch?

Patch 5 is a bit more complicated.
On cards with very little video memory, (e.g 8MB) higher resolutions
at 32bit framebuffer depths will get corrupted because the required
memory is larger than what the framebuffer has. DRM has "max_height"
and "max_width" but no "max_bytes" for limiting resolutions, so the
patch is a little hacky. The first for loop tries to associate a
connector with the mode being tested. From the connector I can get the
bpp if the user specified one on the video= commandline. After that I
do 2 things:
 1) Invalidate the requested mode from the video= parameter
 2) Return MODE_BAD if the framebuffer would be too large
I feel this patch plays with structures it shouldn't have to touch to
get the bpp. An alternative fix would be to include a "max_bytes" in
the DRM core and then do these checks there.

I'm also wondering, did I miss the 3.9.0 merge window?

Thanks,

Christopher Harvey (5):
  drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth
  drm/mgag200: Cleanup: 'fbdev_list' in 'struct mga_fbdev' is not used
  drm/mgag200: Cleanup: Pass driver specific mga_device in driver
    functions
  drm/mgag200: Cleanup: Remove extra variable assigns
  drm/mgag200: Reject modes that are too big for VRAM

 drivers/gpu/drm/mgag200/mgag200_drv.h  |  1 -
 drivers/gpu/drm/mgag200/mgag200_fb.c   |  3 ---
 drivers/gpu/drm/mgag200/mgag200_main.c |  2 --
 drivers/gpu/drm/mgag200/mgag200_mode.c | 34 ++++++++++++++++++++++++++++++----
 4 files changed, 30 insertions(+), 10 deletions(-)

-- 
1.7.12.4

             reply	other threads:[~2013-02-26 16:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 15:52 Christopher Harvey [this message]
2013-02-26 15:53 ` [PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth Christopher Harvey
2013-02-26 23:22   ` Paul Menzel
2013-02-26 15:54 ` [PATCH] drm/mgag200: Cleanup: 'fbdev_list' in 'struct mga_fbdev' is not used Christopher Harvey
2013-02-26 15:54 ` [PATCH] drm/mgag200: Cleanup: Pass driver specific mga_device in driver functions Christopher Harvey
2013-02-26 23:25   ` Paul Menzel
2013-02-26 15:55 ` [PATCH] drm/mgag200: Cleanup: Remove extra variable assigns Christopher Harvey
2013-02-26 23:28   ` Paul Menzel
2013-02-26 15:55 ` [PATCH] drm/mgag200: Reject modes that are too big for VRAM Christopher Harvey
2013-02-26 23:34   ` Paul Menzel
2013-03-07  0:38   ` Dave Airlie
2013-03-06 18:51 ` [PATCH] mgag200: some cleanup and a fix for corrupted output Christopher Harvey
2013-03-06 21:02   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130226155255.GA18595@harvey-pc.matrox.com \
    --to=charvey@matrox.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jlemire@matrox.com \
    --cc=mathieu.larouche@matrox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.