From: Stanislaw Gruszka <sgruszka@redhat.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mac80211: Fix crash due to un-canceled work-items.
Date: Tue, 26 Feb 2013 17:05:36 +0100 [thread overview]
Message-ID: <20130226160536.GC5256@redhat.com> (raw)
In-Reply-To: <1361382069-31729-2-git-send-email-greearb@candelatech.com>
On Wed, Feb 20, 2013 at 09:41:09AM -0800, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> The monitor_work and beacon_connection_loss_work items were
> not being canceled on disassociation (and not on deletion
> either). This leads to work-items trying to run after memory
> has been deleted.
[skip]
>
> + /* Make sure some work items will not run after this.
> + * Have to do this outside the ifmgd->mtx lock.
> + */
> + cancel_work_sync(&ifmgd->monitor_work);
> + cancel_work_sync(&ifmgd->beacon_connection_loss_work);
Other works should be canceled as well. Ben, could you repost
this patch with proper comment?
Stanislaw
next prev parent reply other threads:[~2013-02-26 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 17:41 [PATCH v2 1/2] mac80211: Stop timers before canceling work items greearb
2013-02-20 17:41 ` [PATCH v2 2/2] mac80211: Fix crash due to un-canceled work-items greearb
2013-02-26 16:05 ` Stanislaw Gruszka [this message]
2013-02-26 16:55 ` Ben Greear
2013-02-26 16:02 ` [PATCH v2 1/2] mac80211: Stop timers before canceling work items Stanislaw Gruszka
2013-02-26 21:48 ` Johannes Berg
2013-02-26 21:47 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226160536.GC5256@redhat.com \
--to=sgruszka@redhat.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.