Re: [PATCH to X86 PV MMU Wiki v2] Expand th e bootup section to include ELF and memory layout

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Tue, Feb 26, 2013 at 04:14:25PM +0000, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("[Xen-devel] [PATCH to X86 PV MMU Wiki v2] Expand th e bootup section to include ELF and memory layout"):
> > v2: Integrate Ian's comments.
> 
> There are some formatting oddities in this:
> 
> > +
> > +When guest has started, the kernel image is read and the ELF (PT_NOTE) program is
> 
> This line is too long for a .txt file; it shoudl be 70 or maybe 75.
> This is a problem throughout the file.

Huh? This goes on the Wiki so I am not sure if we need to worry about that.

> 
> > +parsed.The hypervisor looks in the .note sections
> 
> And here is a missing pspace.
> 
> > +can support, and the location of the hypercall page. There are two variants of this:
> > +
> > +; a). A “.note.Xen” section in ELF header conforming to the ELF PT_NOTE format.
> 
> What's the semicolon for ?

For Wiki.
> 
> Your file has some kind of high-bit-set characters in it which I don't
> think are desirable here ?

Not sure why they show up, but they are OK in the Wiki.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel