From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759878Ab3BZT1U (ORCPT ); Tue, 26 Feb 2013 14:27:20 -0500 Received: from mail-we0-f178.google.com ([74.125.82.178]:44304 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756619Ab3BZT1S (ORCPT ); Tue, 26 Feb 2013 14:27:18 -0500 From: Grant Likely Subject: Re: [PATCH 4/4] gpiolib: rename local offset variables to "hwgpio" To: Alexandre Courbot Cc: Linus Walleij , Ryan Mallon , linux-kernel@vger.kernel.org, gnurou@gmail.com, Alexandre Courbot In-Reply-To: <1360907177-6468-5-git-send-email-acourbot@nvidia.com> References: <1360907177-6468-1-git-send-email-acourbot@nvidia.com> <1360907177-6468-5-git-send-email-acourbot@nvidia.com> Date: Tue, 26 Feb 2013 17:51:54 +0000 Message-Id: <20130226175154.D56DE3E167A@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Feb 2013 14:46:17 +0900, Alexandre Courbot wrote: > Their value being obtained by gpio_chip_hwgpio(), this better reflects > their use. > > Signed-off-by: Alexandre Courbot I'm not going to bother with this one. It is churn on things that are only local variables with no functional change. I would be more inclined if it was something globably visable, but locals are easy to grok. g.