From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools/xc: update tty detection in
 stdiostream_progress
Date: Wed, 27 Feb 2013 14:37:40 +0100
Message-ID: <20130227133740.GA1822@aepfle.de>
References: <1b36a6c0a956cc94ddb0.1361563725@probook.site>
	<20780.62185.634588.412741@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20780.62185.634588.412741@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Feb 26, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH] tools/xc: update tty detection in stdiostream_progress"):
> > tools/xc: update tty detection in stdiostream_progress
> > 
> > As suggested by IanJ:
> > Check isatty only once to preserve the errno of ->progress users, and to
> > reduce the noice in strace output.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Thanks.  But how did you test this ?  It doesn't compile.

I noticed that compiler error but forgot to do qrefresh before sending.

> Also I think it would be better to name the struct member something
> other than "isatty" since that's also the function name.  In theory it
> should be OK but in practice I worry about compiler warnings etc.
> 
> How about "tty" ?

Will rename the member to tty and resend.

Olaf