Re: [PATCH 1/1] kernel/nsproxy.c: Improving a snippet of code.

[Serge Hallyn <serge.hallyn@ubuntu.com>]

Quoting Raphael S.Carvalho (raphael.scarv@gmail.com):
> It seems GCC generates a better code in that way, so I changed that statement.
> Btw, they have the same semantic, so I'm sending this patch due to performance issues.
> 
> Signed-off-by: Raphael S.Carvalho <raphael.scarv@gmail.com>

Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

> ---
>  kernel/nsproxy.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
> index 78e2ecb..21da3d1 100644
> --- a/kernel/nsproxy.c
> +++ b/kernel/nsproxy.c
> @@ -148,7 +148,8 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
>  	 * means share undolist with parent, so we must forbid using
>  	 * it along with CLONE_NEWIPC.
>  	 */
> -	if ((flags & CLONE_NEWIPC) && (flags & CLONE_SYSVSEM)) {
> +	if ((flags & (CLONE_NEWIPC | CLONE_SYSVSEM)) ==
> +		(CLONE_NEWIPC | CLONE_SYSVSEM)) {
>  		err = -EINVAL;
>  		goto out;
>  	}
> -- 
> 1.7.2.5
>