From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
stable <stable@vger.kernel.org>,
Ezequiel Garcia <elezegarcia@gmail.com>
Subject: Re: [PATCH][3.9] ftrace: Update the kconfig for DYNAMIC_FTRACE
Date: Thu, 28 Feb 2013 10:13:06 +0100 [thread overview]
Message-ID: <20130228091306.GA6950@gmail.com> (raw)
In-Reply-To: <1362021805.1231.18.camel@gandalf.local.home>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Ingo,
>
> At ELC I watched a presentation by Ezequiel about a tool he wrote to
> analyze memory wasted by kmalloc and friends. He incorrectly stated that
> you need to enable DYNAMIC_FTRACE in order to get events. I pointed out
> that this was incorrect, but he showed me that the prompt for
> DYNAMIC_FTRACE said it enabled/disabled ftrace tracepoints dynamically.
> And sure enough, it did say that. But this was written when ftrace was
> first created and hasn't been updated since. It was written well before
> tracepoints made it into the kernel. Heck, it even references that damn
> daemon!
>
> As the merge window is still opened, and even if it wasn't, this fix
> should go mainline ASAP. It should also go into stable. This is
> definitely a bug. It may only be documentation (which means it's low
> risk to add), but it's documentation on how to set up your kernel, and
> that being wrong creates unexpected results for the user. Just like any
> other bug would.
>
> Please pull the latest tip/perf/urgent tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> tip/perf/urgent
>
> Head SHA1: db05021d49a994ee40a9735d9c3cb0060c9babb8
>
>
> Steven Rostedt (1):
> ftrace: Update the kconfig for DYNAMIC_FTRACE
>
> ----
> kernel/trace/Kconfig | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
Pulled, thanks Steve!
Ingo
prev parent reply other threads:[~2013-02-28 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 3:23 [PATCH][3.9] ftrace: Update the kconfig for DYNAMIC_FTRACE Steven Rostedt
2013-02-28 9:13 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228091306.GA6950@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=elezegarcia@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.