All of lore.kernel.org
 help / color / mirror / Atom feed
From: majianpeng <majianpeng@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: [PATCH 3/4] md: Don't do normal-write on unresync area of replacement-disk.
Date: Thu, 28 Feb 2013 15:50:37 +0800	[thread overview]
Message-ID: <201302281550356268273@gmail.com> (raw)

Replacement is a fullsync which don't depent on bitmap.So regardless of
the presence and absence of bitmap, it do full resync.
If offset of normal io is larger than offset of resync,it will write
again when resync arrived this offset.

Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
 drivers/md/raid1.c  |    4 +++-
 drivers/md/raid10.c |    4 +++-
 drivers/md/raid5.c  |    3 ++-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index d5bddfc..142a5fa 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1173,7 +1173,9 @@ read_again:
 				set_bit(R1BIO_Degraded, &r1_bio->state);
 			continue;
 		}
-
+		if (test_bit(Replacement, &rdev->flags) &&
+			conf->mddev->curr_resync < r1_bio->sector)
+			continue;
 		atomic_inc(&rdev->nr_pending);
 		if (test_bit(WriteErrorSeen, &rdev->flags)) {
 			sector_t first_bad;
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 64d4824..bb11cfb 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1337,7 +1337,9 @@ retry_write:
 			     || test_bit(Unmerged, &rdev->flags)))
 			rdev = NULL;
 		if (rrdev && (test_bit(Faulty, &rrdev->flags)
-			      || test_bit(Unmerged, &rrdev->flags)))
+			|| test_bit(Unmerged, &rrdev->flags) || 
+			(test_bit(Replacement, &rrdev->flags) &&
+			conf->mddev->curr_resync < r10_bio->sector)))
 			rrdev = NULL;
 
 		r10_bio->devs[i].bio = NULL;
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index bd49623..e0a2a39 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -602,7 +602,8 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
 			rdev = NULL;
 		if (rdev)
 			atomic_inc(&rdev->nr_pending);
-		if (rrdev && test_bit(Faulty, &rrdev->flags))
+		if (rrdev && (test_bit(Faulty, &rrdev->flags) ||
+			conf->mddev->curr_resync < sh->sector))
 			rrdev = NULL;
 		if (rrdev)
 			atomic_inc(&rrdev->nr_pending);
-- 
1.7.9.5

             reply	other threads:[~2013-02-28  7:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28  7:50 majianpeng [this message]
2013-03-04  2:04 ` [PATCH 3/4] md: Don't do normal-write on unresync area of replacement-disk NeilBrown
2013-03-04  2:24   ` majianpeng
2013-03-04  5:30     ` NeilBrown
2013-03-05  2:53       ` majianpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302281550356268273@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.