From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't verify buffers after IO errors
Date: Fri, 1 Mar 2013 06:34:12 +1100 [thread overview]
Message-ID: <20130228193412.GP5551@dastard> (raw)
In-Reply-To: <512F79CE.4030502@sgi.com>
On Thu, Feb 28, 2013 at 09:37:50AM -0600, Mark Tinguely wrote:
> On 02/26/13 20:25, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >When we read a buffer, we might get an error from the underlying
> >block device and not the real data. Hence if we get an IO error, we
> >shouldn't run the verifier but instead just pass the IO error
> >straight through.
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
>
> Looks good. needs to go into Linux 3.7/8 stable?
It's not a critical fix - it just makes logs noisy and changes the
error from, say, EIO to EFSCORRUPTED. The end result will be the
same, though....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-28 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 2:25 [PATCH] xfs: don't verify buffers after IO errors Dave Chinner
2013-02-28 15:37 ` Mark Tinguely
2013-02-28 17:24 ` Ben Myers
2013-02-28 19:34 ` Dave Chinner [this message]
2013-03-07 18:46 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228193412.GP5551@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.