From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>,
linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 3/6] ext4: add self-testing infrastructure to do a sanity check
Date: Fri, 1 Mar 2013 11:23:26 +0800 [thread overview]
Message-ID: <20130301032326.GA2765@gmail.com> (raw)
In-Reply-To: <20130301022946.GB10692@gmail.com>
On Fri, Mar 01, 2013 at 10:29:46AM +0800, Zheng Liu wrote:
[snip]
> > > > + if (!ext4_es_is_written(es) && !ext4_es_is_unwritten(es))
> > > > + return;
> > > > +
> > > > + /*
> > > > + * We don't need to worry about the race condition because
> > > > + * caller takes i_data_sem locking.
> > > Yes, and it is good place to assertion that we hold it.
> >
> > A BUG_ON(mutex_is_locked(&inode->i_mutex) will be added.
> ^^^^^^^
> !mutex_is_locked(&inode->i_mutex)
Sigh, it should be !rwsem_is_locked(&EXT4_I(inode)->i_data_sem). Sorry
for the noisy.
Regards,
- Zheng
next prev parent reply other threads:[~2013-03-01 3:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 18:26 [PATCH 0/6] ext4: try to fix up es regressions Zheng Liu
2013-02-28 18:26 ` [PATCH 1/6] ext4: invalidate exntent-status-tree during extent_migration Zheng Liu
2013-02-28 18:26 ` [PATCH 2/6] ext4: improve ext4_es_can_be_merged() to avoid a potential overflow Zheng Liu
2013-02-28 18:26 ` [PATCH 3/6] ext4: add self-testing infrastructure to do a sanity check Zheng Liu
2013-02-28 19:04 ` Dmitry Monakhov
2013-03-01 2:28 ` Zheng Liu
2013-03-01 2:29 ` Zheng Liu
2013-03-01 3:23 ` Zheng Liu [this message]
2013-02-28 18:26 ` [PATCH 4/6] ext4: fix wrong m_len value after unwritten extent conversion Zheng Liu
2013-02-28 18:26 ` [PATCH 5/6] ext4: ext4_split_extent shoult take care about extent zeroout v3 Zheng Liu
2013-02-28 18:26 ` [PATCH 6/6] ext4: update extent status tree after an extent is zeroed out Zheng Liu
2013-02-28 18:45 ` Dmitry Monakhov
2013-03-01 2:37 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301032326.GA2765@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.