All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: linux-iio@vger.kernel.org
Subject: IIO_BUFFER - IIO_TRIGGERED_BUFFER circular dependency
Date: Thu, 28 Feb 2013 20:32:22 -0800	[thread overview]
Message-ID: <20130301043222.GA5606@roeck-us.net> (raw)

Hi all,

IIO_TRIGGERED_BUFFER depends on IIO_BUFFER because of:

drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)

On the other side, it is often selected as follows.

	select IIO_TRIGGERED_BUFFER if (IIO_BUFFER)

For that reason, selecting IIO_BUFFER in the IIO_TRIGGERED_BUFFER declaration
results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selecting
IIO_TRIGGERED_BUFFER is missing, though, which can result in the compile error.

What is the proper solution ?
- Add "if (IIO_BUFFER)" whenever IIO_TRIGGERED_BUFFER is selected
or
- Remove "if (IIO_BUFFER)" from IIO_TRIGGERED_BUFFER selection and add "select
  IIO_BUFFER" to the IIO_TRIGGERED_BUFFER declaration

I would prefer the latter to solve the problem for good.

Thanks,
Guenter

             reply	other threads:[~2013-03-01  4:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01  4:32 Guenter Roeck [this message]
2013-03-01 13:38 ` IIO_BUFFER - IIO_TRIGGERED_BUFFER circular dependency Lars-Peter Clausen
2013-03-01 14:41   ` Guenter Roeck
2013-03-01 15:04     ` Lars-Peter Clausen
2013-03-01 17:20       ` Guenter Roeck
2013-03-02 16:36         ` Jonathan Cameron
2013-03-01 15:16     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130301043222.GA5606@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.