All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: change names of e820 memory map type
Date: Fri, 1 Mar 2013 11:57:05 +0100	[thread overview]
Message-ID: <20130301105705.GA2625@gmail.com> (raw)
In-Reply-To: <1362129067.2262.84.camel@liguang.fnst.cn.fujitsu.com>


* li guang <lig.fnst@cn.fujitsu.com> wrote:

> gratuitous?
> 
> It was inspired by gtk library's key definitions,

I don't think GTK is a shining example of API cleanliness and usability that the 
kernel should strive to imitate, especially not in the naming department...

> gtk original keys like GDK_1, GDK_2, GDK_p, GDK_q, GDK_tab ...
> now they all be changed to GDK_KEY_1, GDK_KEY_2 ...
> do you think it's reasonable?
> or gratuitous?

I think hpa already expressed his opinion about the rename?

Thanks,

	Ingo

  reply	other threads:[~2013-03-01 10:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01  5:27 [PATCH 1/2] x86: change names of e820 memory map type liguang
2013-03-01  5:27 ` [PATCH 2/2] x86: add e820 descriptor attribute field liguang
2013-03-01  5:28   ` H. Peter Anvin
2013-03-01  9:12     ` li guang
2013-03-01  5:29 ` [PATCH 1/2] x86: change names of e820 memory map type H. Peter Anvin
2013-03-01  9:11   ` li guang
2013-03-01 10:57     ` Ingo Molnar [this message]
2013-03-01 15:17     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130301105705.GA2625@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.