From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/edid: kernel-doc minimal cleanup
Date: Fri, 1 Mar 2013 15:47:53 +0200
Message-ID: <20130301134753.GC4469@intel.com>
References: <1362093189-7695-1-git-send-email-nm@ti.com>
	<20130301124350.GB4469@intel.com> <20130301134523.GA20420@kahuna>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1E551E5F53
	for <dri-devel@lists.freedesktop.org>;
	Fri,  1 Mar 2013 05:47:59 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130301134523.GA20420@kahuna>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Nishanth Menon <nm@ti.com>
Cc: Dave Airlie <airlied@redhat.com>, dri-devel <dri-devel@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: dri-devel@lists.freedesktop.org

On Fri, Mar 01, 2013 at 07:45:24AM -0600, Nishanth Menon wrote:
> On 14:43-20130301, Ville Syrj=E4l=E4 wrote:
> > On Thu, Feb 28, 2013 at 05:13:09PM -0600, Nishanth Menon wrote:
> [..]
> > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid);
> > >  =

> > >  #define DDC_SEGMENT_ADDR 0x30
> > >  /**
> > > - * Get EDID information via I2C.
> > > - *
> > > - * \param adapter : i2c device adaptor
> > > - * \param buf     : EDID data buffer to be filled
> > > - * \param len     : EDID data buffer length
> > > - * \return 0 on success or -1 on failure.
> > > + * drm_do_probe_ddc_edid() - Get EDID information via I2C.
> > > + * @adapter:	i2c device adaptor
> > =

> > nit: adapter vs. adaptor
> Thanks for catching it.
> > =

> > > + * @buf:	EDID data buffer to be filled
> > > + * @block:	EDID block to get
> > > + * @len:	EDID data buffer length
> > >   *
> > >   * Try to fetch EDID information by calling i2c driver function.
> > > + * Return 0 on success or -1 on failure.
> > >   */
> > >  static int
> > >  drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *bu=
f,
> > > @@ -1128,10 +1128,10 @@ out:
> > >  }
> > >  =

> > >  /**
> > > - * Probe DDC presence.
> > > + * drm_probe_ddc() - Probe DDC presence
> > > + * @adapter:	i2c device adaptor
> > >   *
> > > - * \param adapter : i2c device adaptor
> > > - * \return 1 on success
> > > + * returns 1 on success
> > >   */
> > >  bool
> > >  drm_probe_ddc(struct i2c_adapter *adapter)
> > > @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b)
> > >  =

> > >  /**
> > >   * drm_mode_std - convert standard mode info (width, height, refresh=
) into mode
> > > + * @connector: connector corresponding to the HDMI/DP sink
> > =

> > EDID isn't limited to HDMI/DP.
> > =

> [..]
> > >  =

> > >  /**
> > >   * drm_rgb_quant_range_selectable - is RGB quantization range select=
able?
> > > + * @edid: EDID data
> > =

> > nit: Different description for the same thing between this and the prev=
ious
> > hunk.
> agreed. How about just EDID data?

Fine by me.

-- =

Ville Syrj=E4l=E4
Intel OTC