From: Grant Likely <grant.likely@secretlab.ca>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Peter Tyser <ptyser@xes-inc.com>,
Jean Delvare <khali@linux-fr.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect
Date: Sat, 02 Mar 2013 09:18:36 +0000 [thread overview]
Message-ID: <20130302091836.1DBD83E15E3@localhost> (raw)
In-Reply-To: <1361978715-14948-1-git-send-email-mika.westerberg@linux.intel.com>
On Wed, 27 Feb 2013 17:25:15 +0200, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether
> the given GPIO is available or not. However, callers of this function treat
> the return value as boolean:
>
> ...
> if (!ichx_gpio_check_available(gpio, nr))
> return -ENXIO;
>
> which erroneusly fails when the GPIO is available and not vice versa.
>
> Fix this by making the function return boolean as expected by the callers.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied, thanks.
g.
next prev parent reply other threads:[~2013-03-03 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 15:25 [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect Mika Westerberg
2013-03-02 9:18 ` Grant Likely [this message]
2013-03-03 13:49 ` Jean Delvare
2013-03-07 3:23 ` Linus Walleij
2013-03-07 6:35 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302091836.1DBD83E15E3@localhost \
--to=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.