From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Girish K S <girishks2000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH V2 3/5] spi: s3c64xx: Added provision for non-gpio i/o's
Date: Sat, 02 Mar 2013 22:56:17 +0000 [thread overview]
Message-ID: <20130302225617.405D23E3209@localhost> (raw)
In-Reply-To: <1360785828-32767-4-git-send-email-ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Wed, 13 Feb 2013 12:03:46 -0800, Girish K S <girishks2000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Currently the drivers supports only the GPIO based i/o pins.
> But there are Exynos SoC's that use the same controller with
> dedicated i/o pins.
>
> This patch provides provision to support gpio/dedicated pins.
> The decision is made by parsing the "gpios" property in the spi
> node.
>
> Signed-off-by: Girish K S <ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> changes in v2:
> Removed the gpio quirk. Parse the "gpios" property
> to decide whether gpio / dedicated i/o lines should
> be used.
It is perfectly valid to support both at the same time. The gpios
property can be 'sparse' in that when a gpio is specified, use that for
the CS control, but use a dedicated line with it is not. Instead of
doing this it would be better off to switch this driver to use the new
cs_gpios parsing in driver/spi/spi.c
g.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
next prev parent reply other threads:[~2013-03-02 22:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 20:03 [PATCH V2 0/5] Add polling support for 64xx spi controller Girish K S
[not found] ` <1360785828-32767-1-git-send-email-ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-02-13 20:03 ` [PATCH V2 1/5] spi: s3c64xx: modified error interrupt handling and init Girish K S
2013-02-13 20:03 ` [PATCH V2 2/5] spi: s3c64xx: added support for polling mode Girish K S
[not found] ` <1360785828-32767-3-git-send-email-ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-03-02 22:58 ` Grant Likely
2013-03-04 6:15 ` Girish KS
2013-02-13 20:03 ` [PATCH V2 3/5] spi: s3c64xx: Added provision for non-gpio i/o's Girish K S
[not found] ` <1360785828-32767-4-git-send-email-ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-03-02 22:56 ` Grant Likely [this message]
2013-03-12 5:30 ` Girish KS
2013-02-13 20:03 ` [PATCH V2 4/5] spi: s3c64xx: Added provision for dedicated cs pin Girish K S
2013-02-13 20:03 ` [PATCH V2 5/5] spi: s3c64xx: Added support for exynos5440 spi Girish K S
-- strict thread matches above, loose matches on Subject: below --
2013-02-13 19:25 [PATCH V2 0/5] Add polling support for 64xx spi controller Girish K S
[not found] ` <1360783531-32654-1-git-send-email-ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-02-13 19:25 ` [PATCH V2 3/5] spi: s3c64xx: Added provision for non-gpio i/o's Girish K S
2013-02-13 19:25 ` Girish K S
2013-02-13 19:25 ` Girish K S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302225617.405D23E3209@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=girishks2000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.