From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Alfredo Jesús Delaiti" <alfredodelaiti@netscape.net>
Cc: linux-media@vger.kernel.org
Subject: Re: mb86a20s and cx23885
Date: Sun, 3 Mar 2013 13:40:51 -0300 [thread overview]
Message-ID: <20130303134051.6dc038aa@redhat.com> (raw)
In-Reply-To: <51336331.10205@netscape.net>
Em Sun, 03 Mar 2013 11:50:25 -0300
Alfredo Jesús Delaiti <alfredodelaiti@netscape.net> escreveu:
> The new data replacement in mb86a20s
>
> /*
> * Initialization sequence: Use whatevere default values that PV SBTVD
> * does on its initialisation, obtained via USB snoop
> */
> static struct regdata mb86a20s_init[] = {
Please test first my mb86a20s patchset. If it doesn't work, we'll need
to dig into the differences.
The better is to group these and reorder them to look like what's there
at the driver, and send it like a diff. That would make a way easier to
see what's different there.
Anyway, it follows my comments about a few things that came into my eyes.
> { 0x09, 0x3a },
No idea what's here, but it seems a worth trial to change it.
> { 0x28, 0x2a },
> { 0x29, 0x00 },
> { 0x2a, 0xfd },
> { 0x2b, 0xc8 },
Hmm... the above may explain why it is not working. This is calculated
from the XTAL frequency, and IF (if different than 4MHz).
Just changing it could fix the issue.
> { 0x28, 0x20 },
> { 0x29, 0x3e },
> { 0x2a, 0xde },
> { 0x2b, 0x4d },
This doesn't matter anymore. It will be now be calculated based on the
frequency you use for IF at the tuner.
The above frequency is not 4MHz.
> { 0x08, 0x1e },
This looks weird. You probably got it wrong.
> { 0x80, 0xdf },
This also looks weird. I suspect that you also lost data here.
Regards,
Mauro
next prev parent reply other threads:[~2013-03-03 16:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51054759.7050202@netscape.net>
2013-01-27 16:16 ` mb86a20s and cx23885 Mauro Carvalho Chehab
2013-01-27 21:48 ` Alfredo Jesús Delaiti
2013-01-27 21:52 ` Fwd: " Alfredo Jesús Delaiti
2013-01-28 10:23 ` Mauro Carvalho Chehab
2013-01-28 20:47 ` Alfredo Jesús Delaiti
2013-02-06 14:12 ` Alfredo Jesús Delaiti
2013-03-03 14:50 ` Alfredo Jesús Delaiti
2013-03-03 16:15 ` Mauro Carvalho Chehab
2013-03-04 23:09 ` Alfredo Jesús Delaiti
2013-03-03 16:40 ` Mauro Carvalho Chehab [this message]
2013-03-04 19:42 ` Mauro Carvalho Chehab
2013-03-05 0:00 ` Alfredo Jesús Delaiti
2013-03-05 2:30 ` Mauro Carvalho Chehab
2013-03-08 22:42 ` Alfredo Jesús Delaiti
2013-04-01 22:41 ` Alfredo Jesús Delaiti
2013-07-15 19:30 ` Alfredo Jesús Delaiti
2013-07-15 20:30 ` Mauro Carvalho Chehab
2013-07-17 13:54 ` Alfredo Jesús Delaiti
2013-07-17 19:23 ` Mauro Carvalho Chehab
2013-07-19 3:38 ` Alfredo Jesús Delaiti
2013-07-21 13:50 ` Alfredo Jesús Delaiti
2013-07-23 20:58 ` Alfredo Jesús Delaiti
2013-07-23 21:46 ` Alfredo Jesús Delaiti
2013-07-27 17:55 ` Alfredo Jesús Delaiti
[not found] ` <20130801090436.6dfa0f68@infradead.org>
2013-08-01 17:16 ` Alfredo Jesús Delaiti
2013-08-01 17:37 ` Mauro Carvalho Chehab
2013-08-01 18:09 ` Alfredo Jesús Delaiti
2013-08-01 18:48 ` Mauro Carvalho Chehab
2013-08-02 3:18 ` Alfredo Jesús Delaiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130303134051.6dc038aa@redhat.com \
--to=mchehab@redhat.com \
--cc=alfredodelaiti@netscape.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.