From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Don't clobber crtc->fb when queue_flip fails Date: Sun, 3 Mar 2013 19:52:33 +0100 Message-ID: <20130303185233.GS9021@phenom.ffwll.local> References: <1361544818-23408-1-git-send-email-ville.syrjala@linux.intel.com> <20130222151300.GH23278@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20130222151300.GH23278@cantiga.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Feb 22, 2013 at 03:13:00PM +0000, Chris Wilson wrote: > On Fri, Feb 22, 2013 at 04:53:38PM +0200, ville.syrjala@linux.intel.c= om wrote: > > From: Ville Syrj=E4l=E4 > >=20 > > Restore crtc->fb to the old framebuffer if queue_flip fails. > >=20 > > While at it, kill the pointless intel_fb temp variable. > >=20 > > v2: Update crtc->fb before queue_flip and restore it back > > after a failure. > >=20 > > Cc: stable@vger.kernel.org > > Signed-off-by: Ville Syrj=E4l=E4 >=20 > Lgtm, either v1 or v2 gets my > Reviewed-by: Chris Wilson > (with a slight preference towards v2 for the sake of paranoia) Picked up for -fixes, thanks for the patch. And can I wish for an i-g-t for this? -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch