From: Arnd Bergmann <arnd@arndb.de>
To: Ley Foon Tan <lftan@altera.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Rob Landley <rob@landley.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/misc: Add Altera System ID driver
Date: Mon, 4 Mar 2013 03:32:19 +0000 [thread overview]
Message-ID: <201303040332.20076.arnd@arndb.de> (raw)
In-Reply-To: <1362366697-2768-1-git-send-email-lftan@altera.com>
On Monday 04 March 2013, Ley Foon Tan wrote:
> This patch is to add Altera System ID driver.
> User can obtain the system ID and timestamp of the system by
> reading the sysfs entry.
>
> Usage:
> cat /sys/bus/platform/devices/[addr].sysid/sysid/id
> cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
>
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
All sysfs files need documentation in Documentation/ABI/.
This driver looks like it should instead be using the infrastructure we
have for identifying an SoC in drivers/base/soc.c, which is currently
only used by the ARM u8500 platform but was introduced as a generic
interface for this a while ago.
Arnd
next prev parent reply other threads:[~2013-03-04 3:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 3:11 [PATCH 1/1] drivers/misc: Add Altera System ID driver Ley Foon Tan
2013-03-04 3:32 ` Arnd Bergmann [this message]
2013-03-04 3:44 ` Greg Kroah-Hartman
2013-03-04 9:41 ` Ley Foon Tan
2013-03-04 12:55 ` Arnd Bergmann
2013-03-05 11:12 ` Ley Foon Tan
2013-03-05 21:59 ` Arnd Bergmann
2013-03-08 10:41 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303040332.20076.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=lftan@altera.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.