All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] Added lcms2 package
Date: Mon, 4 Mar 2013 09:22:16 +0100	[thread overview]
Message-ID: <20130304092216.7d71ea75@skate> (raw)
In-Reply-To: <1362346984-20701-1-git-send-email-olivier.schonken@gmail.com>

Dear Olivier Schonken,

On Sun,  3 Mar 2013 23:43:04 +0200, Olivier Schonken wrote:
> Little CMS intends to be an OPEN SOURCE small-footprint color management engine,
> with special focus on accuracy and performance.
> 
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 (visual inspection only).

I have only one very minor nit, that I think doesn't prevent the patch
from being applied.

> diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
> new file mode 100644
> index 0000000..d648d24
> --- /dev/null
> +++ b/package/lcms2/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_LCMS2
> +	bool "lcms2"
> +	help
> +	  Little Color Management Software
> +	  Little CMS intends to be an OPEN SOURCE small-footprint color 
> +	  management engine, with special focus on accuracy and performance. 
> +	  It uses the International Color Consortium standard (ICC), which is
> +	  the modern standard when regarding to color management.
> +
> +	  http://www.littlecms.com/
> +
> +

One two many empty newline.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-03-04  8:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-02 18:47 [Buildroot] [PATCH 1/1] Added lcms2 package Olivier Schonken
2013-03-03 16:11 ` Thomas Petazzoni
2013-03-03 21:43   ` [Buildroot] [PATCHv2] " Olivier Schonken
2013-03-04  8:22     ` Thomas Petazzoni [this message]
2013-03-16 12:12 ` [Buildroot] [PATCHv3] " Olivier Schonken
2013-03-16 12:42 ` [Buildroot] [PATCH 1/1] " Olivier Schonken
2013-03-18 20:40   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130304092216.7d71ea75@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.