From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: GFDT support for SNB/IVB Date: Mon, 4 Mar 2013 15:51:11 +0200 Message-ID: <20130304135111.GH4469@intel.com> References: <1362162777-21626-1-git-send-email-ville.syrjala@linux.intel.com> <20130303162852.GE9021@phenom.ffwll.local> <20130303173908.GB5364@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 13C4AE64E8 for ; Mon, 4 Mar 2013 05:51:19 -0800 (PST) Content-Disposition: inline In-Reply-To: <20130303173908.GB5364@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Mar 03, 2013 at 05:39:09PM +0000, Chris Wilson wrote: > On Sun, Mar 03, 2013 at 05:28:52PM +0100, Daniel Vetter wrote: > > The other thing was that I didn't manage to get things to work properly, > > leaving some random cachline dirt on the screen. Looking at your code, = you > > add the gfdt flush to every ring_flush, whereas I've tried to be clever > > and only flushed after batches rendering to the frontbuffer. So probabl= y a > > bug in my code, or a flush on a given ring doesn't flush out caches for > > one of the other engines. > = > Right, we have a formalized interface for flushes to scanout rather than > always flushing GFDT. We do? Where's that? -- = Ville Syrj=E4l=E4 Intel OTC