From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 03/10] drm/i915: add pipe_config->timings_set Date: Mon, 4 Mar 2013 16:18:40 +0200 Message-ID: <20130304141840.GJ4469@intel.com> References: <1361491014-13888-1-git-send-email-daniel.vetter@ffwll.ch> <1361491014-13888-4-git-send-email-daniel.vetter@ffwll.ch> <20130222135115.GN4469@intel.com> <20130303180112.GM9021@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 83736E5D21 for ; Mon, 4 Mar 2013 06:18:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <20130303180112.GM9021@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Sun, Mar 03, 2013 at 07:01:12PM +0100, Daniel Vetter wrote: > On Fri, Feb 22, 2013 at 03:51:15PM +0200, Ville Syrj=E4l=E4 wrote: > > On Fri, Feb 22, 2013 at 12:56:47AM +0100, Daniel Vetter wrote: > > > Only used by the lvds encoder. Note that we shouldn't do the same > > > simple conversion with the FORCE_6BPC flag, since that's much better > > > handled by moving all the pipe_bpc computation around. > > > = > > > Signed-off-by: Daniel Vetter > > > --- > > > drivers/gpu/drm/i915/intel_display.c | 12 +++++++++++- > > > drivers/gpu/drm/i915/intel_drv.h | 10 ++++++---- > > > drivers/gpu/drm/i915/intel_lvds.c | 19 +++++++++---------- > > > 3 files changed, 26 insertions(+), 15 deletions(-) > > > = > > > > > @@ -359,6 +357,7 @@ static bool intel_lvds_mode_fixup(struct drm_enco= der *encoder, > > > I915_WRITE(BCLRPAT(pipe), 0); > > > = > > > drm_mode_set_crtcinfo(adjusted_mode, 0); > > > + pipe_config->timings_set =3D true; > > = > > This changes the behaviour a bit. Previously the flag was only set from > > the centering funcs, but now it's set always. Is that intentional? > = > The crtc code also calls drm_mode_set_crtcinfo(adjusted_mode, 0) if > ->timings_set is false, so doesn't result in any behaviour change. Hence > I've figure that fewer lines of code should be better. Want me to change > it back or just add a bit of text to the commit message? E.g. > = > "Note that since the lvds code unconditionally sets the crtc timings, we > can also unconditionally set the respective flag and not just when we set > special timings like the old code did." Right, I should have actually read the code with some thought instead of blindly looking at the changes. I think amending the commit message with the proposed text would be enough. -- = Ville Syrj=E4l=E4 Intel OTC