From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v5 4/9] video: Add generic HDMI infoframe helpers Date: Mon, 4 Mar 2013 16:49:46 +0200 Message-ID: <20130304144946.GK4469@intel.com> References: <1361516611-2517-1-git-send-email-thierry.reding@avionic-design.de> <1361516611-2517-5-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 597FCE6513 for ; Mon, 4 Mar 2013 06:49:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <1361516611-2517-5-git-send-email-thierry.reding@avionic-design.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Thierry Reding Cc: Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Feb 22, 2013 at 08:03:26AM +0100, Thierry Reding wrote: > Add generic helpers to pack HDMI infoframes into binary buffers. > = > Signed-off-by: Thierry Reding > --- > Changes in v2: > - add support for audio, vendor-specific and SPD infoframes > - add various validity checks on infoframes > - factor out checksum computation > = > Changes in v3: > - introduce HDMI_INFOFRAME_HEADER_SIZE > - fix SPD infoframe SDI field offset > = > Changes in v4: > - remove needless checks for input parameters > - use memcpy() instead of manual copy loop > - update SPD SPI enum to include HD-DVD and PMP as per CEA-861-E > - add audio coding type extension support > - match audio coding type names to those in CEA-861-E > = > drivers/video/Kconfig | 3 + > drivers/video/Makefile | 1 + > drivers/video/hdmi.c | 308 +++++++++++++++++++++++++++++++++++++++++++= ++++++ > include/linux/hdmi.h | 231 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 543 insertions(+) > create mode 100644 drivers/video/hdmi.c > create mode 100644 include/linux/hdmi.h > = > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 09f1a18..b11eeab 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -52,6 +52,9 @@ config OF_VIDEOMODE > help > helper to get videomodes from the devicetree > = > +config HDMI > + bool > + > menuconfig FB > tristate "Support for frame buffer devices" > ---help--- > diff --git a/drivers/video/Makefile b/drivers/video/Makefile > index f592f3b..0b50082 100644 > --- a/drivers/video/Makefile > +++ b/drivers/video/Makefile > @@ -5,6 +5,7 @@ > # Each configuration option enables a list of files. > = > obj-$(CONFIG_VGASTATE) +=3D vgastate.o > +obj-$(CONFIG_HDMI) +=3D hdmi.o > obj-y +=3D fb_notify.o > obj-$(CONFIG_FB) +=3D fb.o > fb-y :=3D fbmem.o fbmon.o fbcmap.o fbsysfs.= o \ > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > new file mode 100644 > index 0000000..ab23c9b > --- /dev/null > +++ b/drivers/video/hdmi.c > @@ -0,0 +1,308 @@ > +/* > + * Copyright (C) 2012 Avionic Design GmbH > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ BTW was there any discussion about the license? drm is generally MIT. Are people OK with depending on GPL code for infoframe support? -- = Ville Syrj=E4l=E4 Intel OTC