From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 2/2] x86/Intel: Add missing Merom, Westmere,
 and Nehelem models.
Date: Mon, 4 Mar 2013 13:01:51 -0500
Message-ID: <20130304180151.GA11245@phenom.dumpdata.com>
References: <1362148308-4429-1-git-send-email-konrad.wilk@oracle.com>
	<1362148308-4429-3-git-send-email-konrad.wilk@oracle.com>
	<5130DCF702000078000C271B@nat28.tlf.novell.com>
	<1738683.aq3Wrk796J@amur>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1738683.aq3Wrk796J@amur>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Cc: boris.ostrovsky@oracle.com, Jan Beulich <JBeulich@suse.com>, jun.nakajima@intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Mar 04, 2013 at 09:15:35AM +0100, Dietmar Hahn wrote:
> Am Freitag 01 M=E4rz 2013, 15:53:11 schrieb Jan Beulich:
> > >>> On 01.03.13 at 15:31, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com=
> wrote:
> > > Mainly 22 (Merom-L); 30 (Nehelem); and 37, 44 (Westmere).
> > =

> > Assuming Intel confirms this, I'm fine with adding those.
> > =

> > > --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c
> > > +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c
> > > @@ -738,14 +738,25 @@ int vmx_vpmu_initialise(struct vcpu *v, unsigne=
d int vpmu_flags)
> > >      {
> > >          switch ( cpu_model )
> > >          {
> > > +        /* Core2: */
> > >          case 15: /* original 65 nm celeron/pentium/core2/xeon, "Mero=
m"/"Conroe" */
> > > +        case 22: /* single-core 65 nm celeron/core2solo "Merom-L"/"C=
onroe-L" */
> > >          case 23: /* current 45 nm celeron/core2/xeon "Penryn"/"Wolfd=
ale" */
> > > -        case 26: /* 45 nm nehalem, "Bloomfield" */
> > >          case 29: /* six-core 45 nm xeon "Dunnington" */
> > > +
> > >          case 42: /* SandyBridge */
> > >          case 45: /* SandyBridge, "Romely-EP" */
> > > +
> > > +        /* Nehelem: */
> > =

> > Nehalem
> > =

> > > +        case 26: /* 45 nm nehalem, "Bloomfield" */
> > > +        case 30: /* 45 nm nehalem, "Lynnfield" */
> > >          case 46: /* 45 nm nehalem-ex, "Beckton" */
> > > +
> > > +        /* Westmere: */
> > > +        case 37: /* 32 nm nehalem, "Clarkdale" */
> > > +        case 44: /* 32 nm nehalem, "Gulftown" */
> > >          case 47: /* 32 nm Xeon E7 */
> > > +
> > >          case 58: /* IvyBridge */
> > >          case 62: /* IvyBridge EP */
> > >              ret =3D core2_vpmu_initialise(v, vpmu_flags);
> > =

> > I guess the main reason these weren't here is that no-one actively
> > tested the code on them. Fujitsu has been completing this list as
> > they ran into systems missing here yet they were able to test on...
> =

> Yes we did some extensions but only with processors we were able to test
> because we ran into trouble with some of these.

What were those problems? Could you report them on xen-devel please?