All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] lua: remove built dependencies
Date: Mon, 4 Mar 2013 22:24:14 +0100	[thread overview]
Message-ID: <20130304222414.17c0fce3@skate> (raw)
In-Reply-To: <1355564002-14490-1-git-send-email-francois.perrad@gadz.org>

Dear Francois Perrad,

On Sat, 15 Dec 2012 10:33:21 +0100, Francois Perrad wrote:
> runtime dependencies are handled in Config.in
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

If those are runtime dependencies only, then you need to update the
Config.in file to add a comment explaining that it's a runtime
dependency. Generally, when a package selects another one in its
Config.in, we expect the .mk file to have this dependency as well. When
it's not the case, we want a comment that explains why.

	# Runtime dependency only	
	select BR2_PACKAGE_LUAFILESYSTEM

Could you post an updated version of your [PATCH 1/2] with this change?

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      parent reply	other threads:[~2013-03-04 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-15  9:33 [Buildroot] [PATCH 1/2] lua: remove built dependencies Francois Perrad
2012-12-15  9:33 ` [Buildroot] [PATCH 2/2] luajit: allow to build Lua extensions without lua Francois Perrad
2013-03-04 21:29   ` Thomas Petazzoni
2013-01-08  7:36 ` [Buildroot] [PATCH 1/2] lua: remove built dependencies François Perrad
2013-03-04 20:48 ` François Perrad
2013-03-04 21:24 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130304222414.17c0fce3@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.