From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: linux-3.9-rc1: WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x88/0xa0() Device pciback disabling already-disabled device Date: Tue, 5 Mar 2013 11:20:28 -0500 Message-ID: <20130305162028.GD15668@phenom.dumpdata.com> References: <79369661.20130304234323@eikelenboom.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <79369661.20130304234323@eikelenboom.it> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Sander Eikelenboom Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Mar 04, 2013 at 11:43:23PM +0100, Sander Eikelenboom wrote: > Hi Konrad, > > While shuting down a HVM guest with pci devices passed through i get this one below ... > Both dom0 and domU run the same linux-3.9-rc1 (+ Thomas Gleixner patches) OK, that one looks pretty easy to fix: > [ 759.027692] Hardware name: MS-7640 > [ 759.034233] Device pciback > [ 759.034233] disabling already-disabled device ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Could you try the below patch please? diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c index 37c1f82..b98cf0c 100644 --- a/drivers/xen/xen-pciback/pciback_ops.c +++ b/drivers/xen/xen-pciback/pciback_ops.c @@ -113,7 +113,8 @@ void xen_pcibk_reset_device(struct pci_dev *dev) if (dev->msi_enabled) pci_disable_msi(dev); #endif - pci_disable_device(dev); + if (pci_is_enabled(dev)) + pci_disable_device(dev); pci_write_config_word(dev, PCI_COMMAND, 0);