From: Oleg Nesterov <oleg@redhat.com>
To: Michel Lespinasse <walken@google.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
paulmck@linux.vnet.ibm.com, Rusty Russell <rusty@rustcorp.com.au>,
rostedt@goodmis.org, tglx@linutronix.de,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] lglock: update lockdep annotations to report recursive local locks
Date: Tue, 5 Mar 2013 18:42:04 +0100 [thread overview]
Message-ID: <20130305174204.GB5012@redhat.com> (raw)
In-Reply-To: <1362449845-7492-3-git-send-email-walken@google.com>
On 03/04, Michel Lespinasse wrote:
>
> Both issues are easily fixed by indicating to lockdep that lglock's local
> locks are not recursive. We shouldn't use the rwlock acquire/release
> functions here, as lglock doesn't share the same semantics. Instead
> we can base our lockdep annotations on the lock_acquire_shared
> (for local lglock) and lock_acquire_exclusive (for global lglock)
> helpers.
IOW, with this patch lglock looks like rw_semaphore for lockdep...
Again, I can't ack this change, but afaics it is fine.
Oleg.
next prev parent reply other threads:[~2013-03-05 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 2:17 [PATCH 0/2] tighten lglock lockdep annotations Michel Lespinasse
2013-03-05 2:17 ` [PATCH 1/2] lockdep: introduce lock_acquire_exclusive/shared helper macros Michel Lespinasse
2013-03-05 15:19 ` Lai Jiangshan
2013-03-05 15:40 ` Michel Lespinasse
2013-03-05 17:06 ` Oleg Nesterov
2013-03-05 2:17 ` [PATCH 2/2] lglock: update lockdep annotations to report recursive local locks Michel Lespinasse
2013-03-05 17:42 ` Oleg Nesterov [this message]
2013-03-05 18:24 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305174204.GB5012@redhat.com \
--to=oleg@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.